Skip to content

Test Explorer icons don't update on Windows #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svanimpe opened this issue Oct 18, 2024 · 10 comments
Closed

Test Explorer icons don't update on Windows #1149

svanimpe opened this issue Oct 18, 2024 · 10 comments
Labels
bug Something isn't working waiting on input Stalled waiting on Input windows Issue specific to Windows

Comments

@svanimpe
Copy link
Contributor

See the screenshot below.

error-testing

After running unit tests, the results appear in the Test Results pane, but the icons in the Test Explorer don't update. This did work for me on Linux, but not on Windows.

This is a template library project generated with swift package init.
I'm using v1.11.3 with Swift 6.0.1.

@plemarquand
Copy link
Contributor

Thanks for the report @svanimpe. I'm having trouble reproducing the issue. Could you take a look at the attached screen recording and see if there are any differences in how you're reproducing it?

Also, could you paste in the output of swift -v, as well as whether you're using Windows 10 or 11.

Issue1149.mp4

@plemarquand plemarquand added the waiting on input Stalled waiting on Input label Oct 18, 2024
@svanimpe
Copy link
Contributor Author

Hi Paul,

I'm doing the exact same thing.

This is with swift-6.0.1-RELEASE on Windows 11.

@plemarquand
Copy link
Contributor

Interesting. One more question then is what version of VS Code are you running?

@svanimpe
Copy link
Contributor Author

That is 1.94.2

@plemarquand plemarquand removed the waiting on input Stalled waiting on Input label Oct 19, 2024
@plemarquand plemarquand self-assigned this Oct 21, 2024
@plemarquand
Copy link
Contributor

plemarquand commented Oct 21, 2024

I managed to reproduce this using Swift 6.0.1.

The good news is this doesn't reproduce with the 6.1 (trunk development, main) snapshot from Sept 24th. It also doesn't reproduce if you add swift-testing's main branch as a dependency in your Package.swift.

From my investigation on the swift-vscode side, swift-testing version shipped in Swift Windows 6.0.1 is not writing to the JSON event stream. I've reached out to the swift-testing team for more info.

@plemarquand
Copy link
Contributor

OK a bit more information from the swift-testing team. Looks like this Windows regression was fixed by swiftlang/swift#76564 in the 6.0.2 branch (the PR title states 6.0.1, but this is incorrect, it was merged to 6.0.2).

A couple of options to fix this are:

  • Wait for the Swift 6.0.2 release
  • Use the Swift 6.1 trunk development snapshot
  • Declare swift-testing as a dependency in your Package.swift

I'm going to close this as there isn't much vscode-swift can do here. Please feel free to reopen if you are still experiencing this issue with newer Swift toolchains.

@plemarquand
Copy link
Contributor

Actually, I'll keep this open and verify once 6.0.2 is released.

@plemarquand plemarquand reopened this Oct 21, 2024
@github-project-automation github-project-automation bot moved this from Unscreened to In Progress in Swift Extension for Visual Studio Code Oct 21, 2024
@svanimpe
Copy link
Contributor Author

OK. I'll just wait for 6.0.2, as this wasn't the only issue I encountered with 6.0.1.

@plemarquand plemarquand added windows Issue specific to Windows needs verification Issue has been fixed, but requires verification before closing waiting on input Stalled waiting on Input labels Oct 22, 2024
@plemarquand
Copy link
Contributor

@svanimpe 6.0.2 was just released, let me know if you're still seeing the issue: https://www.swift.org/download/

@svanimpe
Copy link
Contributor Author

svanimpe commented Nov 4, 2024

I no longer have this issue with 6.0.2

@svanimpe svanimpe closed this as completed Nov 4, 2024
@plemarquand plemarquand removed the needs verification Issue has been fixed, but requires verification before closing label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on input Stalled waiting on Input windows Issue specific to Windows
Projects
Development

No branches or pull requests

2 participants