Skip to content

SUID types makes typescript indexation too slow. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webblocksapp opened this issue Apr 14, 2023 · 4 comments
Closed

SUID types makes typescript indexation too slow. #207

webblocksapp opened this issue Apr 14, 2023 · 4 comments

Comments

@webblocksapp
Copy link

webblocksapp commented Apr 14, 2023

I'm needing to import a component interface from SUID in order to extend it to build my own component based on SUID.

The issue is when importing SuidTextFieldProps or any AnySuidComponentProps, typescript types indexation becomes too slow in vscode, and makes difficult types autocomplete slowing down the development flow. Every time I do a change in the code, any SUID type take too long to re-load.

ezgif-5-d2181d48ae

@juanrgm
Copy link
Member

juanrgm commented Apr 16, 2023

This is a known issue in MUI. I've tried to minimize the performance impact on TypeScript but it's difficult because of its design limitations.

What version of TypeScript and what CPU do you use?

@webblocksapp
Copy link
Author

webblocksapp commented Apr 17, 2023

Hi @juanrgm thanks for your soon reply.

This is a known issue in MUI. I've tried to minimize the performance impact on TypeScript but it's difficult because of its design limitations.

I'm currently working on a business project where I'm building a company design system using React MUI. Specifically, we're using version 5.10.11, and I haven't encountered any intellisense issues. We have over 20 components that extend from MUI interfaces.

I tried to follow the same approach for a personal project using SUID but intellisense gets stuck when using the library's interfaces.

Those are my machine specs:

MacBook Pro 2020
2,3 GHz Quad-Core Intel Core i7
16 GB 3733 MHz LPDDR4X
Typescript version 4.9.5

@juanrgm
Copy link
Member

juanrgm commented May 11, 2023

Waiting for TypeScript 5.1 (microsoft/TypeScript#53246).

@juanrgm
Copy link
Member

juanrgm commented Jul 5, 2023

TtypeScript 5.1 has already been released.

If you still have problems, open a new issue.

@juanrgm juanrgm closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants