cleanup: use roles constants

Author: COil

config/packages/security.yaml

@@ -71,7 +71,7 @@ security:
 
     # The ROLE_ADMIN role inherits from the ROLE_USER role
     role_hierarchy:
-        !php/const App\Entity\User::ROLE_ADMIN: !php/const App\Entity\User::ROLE_USER
+        ROLE_ADMIN: ROLE_USER
 
 when@test:
     # this configuration simplifies testing URLs protected by the security mechanism

config/packages/twig.yaml

@@ -4,13 +4,6 @@ twig:
         - 'form/layout.html.twig'
         - 'form/fields.html.twig'
 
-    # The following variables are available in all Twig templates
-    globals:
-        # We can use PHP constants (native PHP ones or from the application) thanks
-        # to the !php/const syntax.
-        ROLE_USER: !php/const App\Entity\User::ROLE_USER
-        ROLE_ADMIN: !php/const App\Entity\User::ROLE_ADMIN
-
 when@test:
     twig:
         strict_variables: true

templates/base.html.twig

@@ -55,7 +55,7 @@
                                         </a>
                                     </li>
 
-                                    {% if is_granted(ROLE_ADMIN) %}
+                                    {% if is_granted('ROLE_ADMIN') %}
                                         <li>
                                             <a href="{{ path('admin_post_index') }}">
                                                 <i class="fa fa-lock" aria-hidden="true"></i> {{ 'menu.admin'|trans }}

templates/security/login.html.twig

@@ -67,15 +67,15 @@
                     <tr>
                         <td>john_user</td>
                         <td>kitten</td>
-                        <td><code>{{ ROLE_USER }}</code> ({{ 'help.role_user'|trans }})</td>
+                        <td><code>ROLE_USER</code> ({{ 'help.role_user'|trans }})</td>
                         <td>
                             <button class="btn btn-primary btn-sm" {{ stimulus_action('login', 'prefillJohnUser') }}><i class="fa fa-user"></i></button>
                         </td>
                     </tr>
                     <tr>
                         <td>jane_admin</td>
                         <td>kitten</td>
-                        <td><code>{{ ROLE_ADMIN }}</code> ({{ 'help.role_admin'|trans }})</td>
+                        <td><code>ROLE_ADMIN</code> ({{ 'help.role_admin'|trans }})</td>
                         <td>
                             <button class="btn btn-primary btn-sm" {{ stimulus_action('login', 'prefillJaneAdmin') }}><i class="fa fa-user"></i></button>
                         </td>