Removing NormalModuleReplacementPlugin in favor of a boring alias

Author: weaverryan

controllers-placeholder.json renamed to controllers.json

@@ -17,7 +17,7 @@ var _stimulus = require("stimulus");
 
 var _webpackHelpers = require("stimulus/webpack-helpers");
 
-var _controllersPlaceholder = _interopRequireDefault(require("./webpack/loader!../controllers-placeholder.json"));
+var _controllers = _interopRequireDefault(require("./webpack/loader!@symfony/stimulus-bridge/controllers.json"));
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
 
@@ -32,21 +32,21 @@ function startStimulusApp(context) {
   }
 
   var _loop = function _loop(_controllerName) {
-    if (!_controllersPlaceholder["default"].hasOwnProperty(_controllerName)) {
+    if (!_controllers["default"].hasOwnProperty(_controllerName)) {
       controllerName = _controllerName;
       return "continue";
     }
 
-    _controllersPlaceholder["default"][_controllerName].then(function (module) {
+    _controllers["default"][_controllerName].then(function (module) {
       // Normalize the controller name: remove the initial @ and use Stimulus format
-      _controllerName = _controllerName.substr(1).replace(/_/g, "-").replace(/\//g, "--");
+      _controllerName = _controllerName.substr(1).replace(/_/g, '-').replace(/\//g, '--');
       application.register(_controllerName, module["default"]);
     });
 
     controllerName = _controllerName;
   };
 
-  for (var controllerName in _controllersPlaceholder["default"]) {
+  for (var controllerName in _controllers["default"]) {
     var _ret = _loop(controllerName);
 
     if (_ret === "continue") continue;

dist/index.js

@@ -13,7 +13,7 @@ module.exports = function createControllersModule(config) {
   var autoImportContents = '';
 
   if ('undefined' !== typeof config['placeholder']) {
-    throw new Error('Your controllers.json file was not configured. Did you add the Webpack plugin created by create-controllers-module.js?');
+    throw new Error('Your controllers.json file was not found. Be sure to add a Webpack alias from "@symfony/stimulus-bridge/controllers.json" to *your* controllers.json file.');
   }
 
   if ('undefined' === typeof config['controllers']) {

dist/webpack/create-controllers-module.js

@@ -39,6 +39,6 @@
         "src/",
         "dist/",
         "webpack-helper.js",
-        "controllers-placeholder.json"
+        "controllers.json"
     ]
 }

package.json

@@ -12,10 +12,9 @@
 import { Application } from 'stimulus';
 import { definitionsFromContext } from 'stimulus/webpack-helpers';
 
-// this import is be replaced by the NormalModuleReplacementPlugin
-// to point to the real controllers.json file
-// See create-controllers-module.js
-import symfonyControllers from './webpack/loader!../controllers-placeholder.json';
+// The @symfony/stimulus-bridge/controllers.json should be changed
+// to point to the real controllers.json file via a Webpack alias
+import symfonyControllers from './webpack/loader!@symfony/stimulus-bridge/controllers.json';
 
 export function startStimulusApp(context) {
     const application = Application.start();

src/index.js

@@ -15,7 +15,7 @@ module.exports = function createControllersModule(config) {
 
     if ('undefined' !== typeof config['placeholder']) {
         throw new Error(
-            'Your controllers.json file was not configured. Did you add the Webpack plugin created by create-controllers-module.js?'
+            'Your controllers.json file was not found. Be sure to add a Webpack alias from "@symfony/stimulus-bridge/controllers.json" to *your* controllers.json file.'
         );
     }
 

src/webpack/create-controllers-module.js

@@ -15,7 +15,6 @@
  */
 
 const path = require('path');
-const createStimulusBridgePlugin = require('../src/webpack/plugin');
 
 module.exports = {
     target: 'node',
@@ -27,5 +26,9 @@ module.exports = {
         path: path.resolve(__dirname, 'dist'),
         libraryTarget: 'commonjs2',
     },
-    plugins: [createStimulusBridgePlugin(path.resolve(__dirname, './controllers.json'))],
+    resolve: {
+        alias: {
+            '@symfony/stimulus-bridge/controllers.json': path.resolve(__dirname, './controllers.json'),
+        },
+    },
 };