Skip to content

Commit 8cf4923

Browse files
bug #54484 [Serializer] reset backed_enum priority, and re-prioritise translatable (GwendolenLynch)
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Serializer] reset backed_enum priority, and re-prioritise translatable | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54478 Fix api-platform/core#6285 Fix api-platform/core#6279 | License | MIT - `serializer.normalizer.translatable` -920 (was -890) - `serializer.normalizer.backed_enum` -915 (originally -915, changed to -880) Floating this as as solution to the knock-on issues from #54478 Context: - #54478 (comment) - api-platform/core#6288 Commits ------- b559aa5 [Serializer] reset backed_enum priority, and re-prioritise translatable
2 parents 39d989a + b559aa5 commit 8cf4923

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116

117117
->set('serializer.normalizer.translatable', TranslatableNormalizer::class)
118118
->args(['$translator' => service('translator')])
119-
->tag('serializer.normalizer', ['priority' => -890])
119+
->tag('serializer.normalizer', ['priority' => -920])
120120

121121
->set('serializer.normalizer.form_error', FormErrorNormalizer::class)
122122
->tag('serializer.normalizer', ['priority' => -915])
@@ -219,6 +219,6 @@
219219
])
220220

221221
->set('serializer.normalizer.backed_enum', BackedEnumNormalizer::class)
222-
->tag('serializer.normalizer', ['priority' => -880])
222+
->tag('serializer.normalizer', ['priority' => -915])
223223
;
224224
};

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php

+16-1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
7070
use Symfony\Component\Serializer\Mapping\Loader\XmlFileLoader;
7171
use Symfony\Component\Serializer\Mapping\Loader\YamlFileLoader;
72+
use Symfony\Component\Serializer\Normalizer\BackedEnumNormalizer;
7273
use Symfony\Component\Serializer\Normalizer\ConstraintViolationListNormalizer;
7374
use Symfony\Component\Serializer\Normalizer\DataUriNormalizer;
7475
use Symfony\Component\Serializer\Normalizer\DateIntervalNormalizer;
@@ -1606,10 +1607,24 @@ public function testTranslatableNormalizerRegistered()
16061607
$tag = $definition->getTag('serializer.normalizer');
16071608

16081609
$this->assertSame(TranslatableNormalizer::class, $definition->getClass());
1609-
$this->assertSame(-890, $tag[0]['priority']);
1610+
$this->assertSame(-920, $tag[0]['priority']);
16101611
$this->assertEquals(new Reference('translator'), $definition->getArgument('$translator'));
16111612
}
16121613

1614+
/**
1615+
* @see https://github.com/symfony/symfony/issues/54478
1616+
*/
1617+
public function testBackedEnumNormalizerRegistered()
1618+
{
1619+
$container = $this->createContainerFromFile('full');
1620+
1621+
$definition = $container->getDefinition('serializer.normalizer.backed_enum');
1622+
$tag = $definition->getTag('serializer.normalizer');
1623+
1624+
$this->assertSame(BackedEnumNormalizer::class, $definition->getClass());
1625+
$this->assertSame(-915, $tag[0]['priority']);
1626+
}
1627+
16131628
public function testSerializerCacheActivated()
16141629
{
16151630
$container = $this->createContainerFromFile('serializer_enabled');

0 commit comments

Comments
 (0)