Skip to content

Commit 61d79b6

Browse files
committed
minor #2940 [Icons] Some fixes on LiveComponent assets (Kocal)
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Icons] Some fixes on LiveComponent assets | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Fixing some incoherent things found in #2935, each commit are separated and contains a link to the comment explaing why Commits ------- c3be957 [Icons] Make `idiomorph` as a devDependency, since it's inlined in dist files (#2935 (comment)) a5bae94 [Icons] Move `assets/styles/live.css` to `assets/src/`, like other packages (#2935 (comment))
2 parents de41ba3 + c3be957 commit 61d79b6

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

pnpm-lock.yaml

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/LiveComponent/assets/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"main": "dist/live_controller.js",
1818
"types": "dist/live_controller.d.ts",
1919
"config": {
20-
"css_source": "styles/live.css"
20+
"css_source": "src/live.css"
2121
},
2222
"scripts": {
2323
"build": "tsx ../../../bin/build_package.ts .",
@@ -44,9 +44,6 @@
4444
"@symfony/ux-live-component": "path:%PACKAGE%/dist/live_controller.js"
4545
}
4646
},
47-
"dependencies": {
48-
"idiomorph": "^0.3.0"
49-
},
5047
"peerDependencies": {
5148
"@hotwired/stimulus": "^3.0.0"
5249
},
@@ -56,6 +53,7 @@
5653
"@testing-library/jest-dom": "catalog:",
5754
"@testing-library/user-event": "^13.1.9",
5855
"@types/node-fetch": "^2.6.2",
56+
"idiomorph": "^0.3.0",
5957
"jsdom": "catalog:",
6058
"node-fetch": "^2.6.1",
6159
"tslib": "catalog:",

src/LiveComponent/assets/src/live.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
[data-loading=""],
2+
[data-loading="show"],
3+
[data-loading*="|show"] {
4+
display: none;
5+
}

src/LiveComponent/assets/styles/live.css

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)