Skip to content

Commit 67577a4

Browse files
committed
minor #9 feat: setup Yarn workspaces (Kocal)
This PR was squashed before being merged into the main branch. Discussion ---------- feat: setup Yarn workspaces Hi! 👋 Since this repository is a multi-packages repository, I thought it would be interesting and useful to use Yarn workspaces on it (since we use Yarn). This will prevent some code duplications (e.g.: in the CI) and make it more "DX-friendly" if you want to build, test, lint (... 👀) all packages in one time: ![Capture d’écran de 2020-12-05 10-30-07](https://user-images.githubusercontent.com/2103975/101239050-e0639c80-36e4-11eb-98a9-72298e6124a6.png) What do you think? Thanks! Commits ------- fb65d0f feat: setup Yarn workspaces
2 parents 1c041b1 + fb65d0f commit 67577a4

File tree

8 files changed

+13
-35
lines changed

8 files changed

+13
-35
lines changed

.github/workflows/test.yaml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -85,23 +85,5 @@ jobs:
8585
runs-on: ubuntu-latest
8686
steps:
8787
- uses: actions/checkout@master
88-
- name: Chartjs
89-
run: |
90-
cd src/Chartjs/Resources/assets
91-
yarn
92-
yarn test
93-
- name: Cropperjs
94-
run: |
95-
cd src/Cropperjs/Resources/assets
96-
yarn
97-
yarn test
98-
- name: Dropzone
99-
run: |
100-
cd src/Dropzone/Resources/assets
101-
yarn
102-
yarn test
103-
- name: LazyImage
104-
run: |
105-
cd src/LazyImage/Resources/assets
106-
yarn
107-
yarn test
88+
- run: yarn
89+
- run: yarn test

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
11
.php_cs.cache
2+
node_modules
3+
yarn.lock
4+
yarn-error.log

package.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"private": true,
3+
"workspaces": ["src/*/Resources/assets"],
4+
"scripts": {
5+
"build": "yarn workspaces run build",
6+
"test": "yarn workspaces run test"
7+
}
8+
}

src/Chartjs/Resources/assets/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/Cropperjs/Resources/assets/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/Dropzone/Resources/assets/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/LazyImage/Resources/assets/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/Swup/Resources/assets/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)