Skip to content

[5pt] Improve the metrics doc #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 tasks
patiencedaur opened this issue Oct 14, 2021 · 1 comment
Closed
9 tasks

[5pt] Improve the metrics doc #2376

patiencedaur opened this issue Oct 14, 2021 · 1 comment
Labels
ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) metrics rewrite [nature] Revise existing text for structure/phrasing/terms

Comments

@patiencedaur
Copy link
Contributor

patiencedaur commented Oct 14, 2021

Improve the metrics documentation

Follow-up on tarantool/metrics#310.

Product: metrics
Audience/target: dev
Root document: https://tarantool.io/en/doc/latest/book/monitoring/
SME: @ yngvar-antonsson

Details

For more info about collectors, check the Prometheus documentation---they are very similar.

The documentation on the metrics module is quite entangled now. Here are some ideas:

  • Add introductory text describing each chapter's contents
  • API: Move the description of the observation object to a more appropriate place (top?)
  • API: consider defining summary-specific concepts in a separate section. Currently the description of summary object parameters looks way overloaded. Maybe connect them with the 'observation' object description. As for quantiles, consider creating a special .. note::. See the Prometheus doc for ideas how to organize this
  • API: take out the description of label_pairs from function parameters to a separate place. This way the reader doesn't have to figure it out from context or learn about it post factum
  • API: explain the difference between collectors
  • API: if histogram and summary are "sets" of collectors (as defined in the note sections), why list them among the collectors?
  • Distinguish between the list of collector names provided in the API chapter and the list provided in the "metrics reference". This might involve some refactoring
  • Use similar syntax and formatting for similar sentences. For example, use the imperative mood for all function definitions ("Remove ...", not "Removes ...")
  • Bring the API doc in accordance with our style guide. For example, always specify return values and types; consider adding the "Possible errors" section to the functions; make function descriptions overall consistent.
@patiencedaur patiencedaur added ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) rewrite [nature] Revise existing text for structure/phrasing/terms labels Oct 14, 2021
@patiencedaur patiencedaur changed the title Improve the metrics doc [5pt] Improve the metrics doc Oct 14, 2021
@veod32 veod32 added this to the metrics milestone Jan 13, 2022
@TarantoolBot TarantoolBot removed the 5sp label Jun 7, 2023
@veod32 veod32 removed this from the metrics milestone Jun 17, 2023
@veod32 veod32 added the metrics label Jun 17, 2023
@andreyaksenov
Copy link
Contributor

Metrics docs were improved when updating them to using Tarantool 3.x: #4348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem [area] Task relates to Tarantool's ecosystem (connector, module, other non-server functionality) metrics rewrite [nature] Revise existing text for structure/phrasing/terms
Projects
None yet
Development

No branches or pull requests

4 participants