crud: remove NewEncoder/NewDecoder from the API

This is only needed for tests. Let it be private API.

Part of #271

Author: oleg-jukovec

crud/msgpack.go

@@ -23,7 +23,3 @@ type MapObject map[string]interface{}
 func (o MapObject) EncodeMsgpack(enc *encoder) {
 	enc.Encode(o)
 }
-
-func NewEncoder(w io.Writer) *encoder {
-	return msgpack.NewEncoder(w)
-}

crud/msgpack_helper_test.go

@@ -0,0 +1,10 @@
+//go:build !go_tarantool_msgpack_v5
+// +build !go_tarantool_msgpack_v5
+
+package crud_test
+
+import (
+	"gopkg.in/vmihailenco/msgpack.v2"
+)
+
+var newEncoder = msgpack.NewEncoder

crud/msgpack_v5.go

@@ -23,7 +23,3 @@ type MapObject map[string]interface{}
 func (o MapObject) EncodeMsgpack(enc *encoder) {
 	enc.Encode(o)
 }
-
-func NewEncoder(w io.Writer) *encoder {
-	return msgpack.NewEncoder(w)
-}

crud/msgpack_v5_helper_test.go

@@ -0,0 +1,10 @@
+//go:build go_tarantool_msgpack_v5
+// +build go_tarantool_msgpack_v5
+
+package crud_test
+
+import (
+	"github.com/vmihailenco/msgpack/v5"
+)
+
+var newEncoder = msgpack.NewEncoder

crud/request_test.go

@@ -94,12 +94,12 @@ var resolver ValidSchemeResolver
 func assertBodyEqual(t testing.TB, reference tarantool.Request, req tarantool.Request) {
 	t.Helper()
 
-	reqBody, err := test_helpers.ExtractRequestBody(req, &resolver, crud.NewEncoder)
+	reqBody, err := test_helpers.ExtractRequestBody(req, &resolver, newEncoder)
 	if err != nil {
 		t.Fatalf("An unexpected Response.Body() error: %q", err.Error())
 	}
 
-	refBody, err := test_helpers.ExtractRequestBody(reference, &resolver, crud.NewEncoder)
+	refBody, err := test_helpers.ExtractRequestBody(reference, &resolver, newEncoder)
 	if err != nil {
 		t.Fatalf("An unexpected Response.Body() error: %q", err.Error())
 	}

crud/tarantool_test.go

@@ -123,7 +123,7 @@ func BenchmarkCrud(b *testing.B) {
 
 	buf := bytes.Buffer{}
 	buf.Grow(512 * 1024 * 1024) // Avoid allocs in test.
-	enc := crud.NewEncoder(&buf)
+	enc := newEncoder(&buf)
 
 	b.ResetTimer()