Reset callbacks on hotreload (#406)

Author: yngvar-antonsson

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - `tnt_synchro_queue_len` metric type
+- Reset callbacks on hotreload
 
 ## [0.15.0] - 2022-08-09
 ### Fixed

metrics/init.lua

@@ -16,6 +16,8 @@ local registry = rawget(_G, '__metrics_registry')
 if not registry then
     registry = Registry.new()
 end
+registry.callbacks = {}
+
 rawset(_G, '__metrics_registry', registry)
 
 local hotreload = package.loaded['cartridge.hotreload']

test/integration/cartridge_hotreload_test.lua

@@ -230,3 +230,23 @@ g.test_cartridge_hotreload_not_reset_collectors = function()
         value = 1,
     })
 end
+
+g.test_cartridge_hotreload_reset_callbacks = function()
+    local main_server = g.cluster:server('main')
+    upload_config()
+
+    local len_before_hotreload = main_server:exec(function()
+        local test_utils = require('test.utils')
+        local Registry = rawget(_G, '__metrics_registry')
+        return test_utils.len(Registry.callbacks)
+    end)
+
+    reload_roles()
+
+    local len_after_hotreload = main_server:exec(function()
+        local test_utils = require('test.utils')
+        local Registry = rawget(_G, '__metrics_registry')
+        return test_utils.len(Registry.callbacks)
+    end)
+    t.assert_equals(len_before_hotreload, len_after_hotreload)
+end

test/metrics_test.lua

@@ -138,3 +138,21 @@ g.test_default_metrics_clear = function()
     metrics.invoke_callbacks()
     t.assert(#metrics.collect() > 0)
 end
+
+g.test_hotreload_remove_callbacks = function()
+    metrics.enable_default_metrics()
+
+    local Registry = rawget(_G, '__metrics_registry')
+    local len_before_hotreload = utils.len(Registry.callbacks)
+    t.assert_gt(len_before_hotreload, 0)
+
+    package.loaded['metrics'] = nil
+
+    metrics = require('metrics')
+    metrics.enable_default_metrics()
+
+    Registry = rawget(_G, '__metrics_registry')
+    local len_after_hotreload = utils.len(Registry.callbacks)
+
+    t.assert_equals(len_before_hotreload, len_after_hotreload)
+end