Skip to content

Port to CMake #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knazarov opened this issue Oct 8, 2019 · 7 comments
Closed

Port to CMake #24

knazarov opened this issue Oct 8, 2019 · 7 comments
Labels
feature A new functionality

Comments

@knazarov
Copy link
Contributor

knazarov commented Oct 8, 2019

Currently the list of files to be installed is hardcoded in both the rockspec and the rpm spec. This should not happen. Instead, the package should be installed with 'make install'.

Please port the build script from Makefile to CMake, and implement packing for debian (now absent)

@yngvar-antonsson yngvar-antonsson added the feature A new functionality label Dec 1, 2020
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Jan 30, 2021
@vasiliy-t vasiliy-t removed the Stale label Feb 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 2, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Apr 2, 2021
@Totktonada
Copy link
Member

Blocks like this one:

%files
%dir %{luapkgdir}/metrics
%{luapkgdir}/metrics/init.lua
%{luapkgdir}/metrics/http_middleware.lua
%{luapkgdir}/metrics/registry.lua
%{luapkgdir}/metrics/quantile.lua

Can be replaced with just:

%files
    %{luapkgdir}/metrics

(Yep, without %{dir}.)

A rockspec can use 'make' build type (and don't list lua files), so if you don't need cmake for various cross-platform stuff, you're free to avoid it.

@github-actions github-actions bot removed the Stale label Apr 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Jun 2, 2021
@Totktonada
Copy link
Member

@vasiliy-t Is there a way to at least protect some issues from this bot? I still think that it is meaningless for managing 20-30 issues (see here), but excluding some issues will at least solve the problem for tasks that I'm interesting in.

@github-actions github-actions bot removed the Stale label Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Aug 5, 2021
@rosik rosik added teamS and removed teamS labels Sep 3, 2021
@LeonidVas LeonidVas removed the teamE label Oct 4, 2022
@filonenko-mikhail filonenko-mikhail changed the title Port to CMake and implement packing for debian Port to CMake Apr 11, 2023
@filonenko-mikhail
Copy link
Contributor

Port to cmake is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

No branches or pull requests

7 participants