Skip to content

Refactor metrics.utils to avoid duplicate code #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yngvar-antonsson opened this issue Jul 30, 2021 · 0 comments · Fixed by #291
Closed

Refactor metrics.utils to avoid duplicate code #277

yngvar-antonsson opened this issue Jul 30, 2021 · 0 comments · Fixed by #291
Labels
refactoring Code refactoring

Comments

@yngvar-antonsson
Copy link
Collaborator

This is weird. Use utils.set_gaugeinstead of copy-pasting the code.

Originally posted by @rosik in #268 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor metrics.utils and change type of luajit metrics tarantool/metrics
2 participants
@kyukhin @yngvar-antonsson