Improve awaiting Tarantool start/stop processes

Add await-versions of start/stop commands for TarantoolControl class.
Improve the waiting process with an extra monitoring PID of a running
Tarantool-instance using terminal ps-command.

Fixes: #164

Author: nicktorwald

src/test/java/org/tarantool/AbstractTarantoolConnectorIT.java

@@ -235,12 +235,10 @@ protected List<?> consoleDelete(String spaceName, Object key) {
 
     protected static void stopTarantool(String instance) {
         control.stop(instance);
-        control.waitStopped("jdk-testing");
     }
 
     protected static void startTarantool(String instance) {
-        control.start(instance);
-        control.waitStarted("jdk-testing");
+        control.start(instance, true);
     }
 
     /**

src/test/java/org/tarantool/AbstractTarantoolSQLConnectorIT.java

@@ -131,12 +131,10 @@ protected static TarantoolConsole openConsole(String instance) {
 
     protected static void stopTarantool(String instance) {
         control.stop(instance);
-        control.waitStopped("jdk-testing");
     }
 
     protected static void startTarantool(String instance) {
-        control.start(instance);
-        control.waitStarted("jdk-testing");
+        control.start(instance, true);
     }
 
 }

src/test/java/org/tarantool/ClientReconnectClusterIT.java

@@ -29,7 +29,8 @@ public class ClientReconnectClusterIT {
         AbstractTarantoolConnectorIT.password,
         "localhost:" + PORTS[0],
         "localhost:" + PORTS[1],
-        "localhost:" + PORTS[2]);
+        "localhost:" + PORTS[2]
+    );
 
     // Resume replication faster in case of temporary failure to fit TIMEOUT.
     private static double REPLICATION_TIMEOUT = 0.1;
@@ -59,9 +60,10 @@ public static void tearDownEnv() {
 
     @Test
     public void testRoundRobinReconnect() {
-        control.start(SRV1);
-        control.start(SRV2);
-        control.start(SRV3);
+        // start instances simultaneously to sync up them
+        control.start(SRV1, false);
+        control.start(SRV2, false);
+        control.start(SRV3, false);
 
         control.waitStarted(SRV1);
         control.waitStarted(SRV2);

src/test/java/org/tarantool/ClientReconnectIT.java

@@ -26,6 +26,7 @@
 import java.util.concurrent.locks.LockSupport;
 
 public class ClientReconnectIT extends AbstractTarantoolConnectorIT {
+
     private static final String INSTANCE_NAME = "jdk-testing";
     private TarantoolClient client;
 
@@ -99,7 +100,7 @@ public SocketChannel get(int retryNumber, Throwable lastError) {
         client.syncOps().ping();
 
         // The park() will return inside connector thread.
-        LockSupport.unpark(((TarantoolClientImpl)client).connector);
+        LockSupport.unpark(((TarantoolClientImpl) client).connector);
 
         // Wait on latch as a proof that reconnect did not happen.
         // In case of a failure, latch will reach 0 before timeout occurs.
@@ -213,11 +214,54 @@ public void run() {
         });
     }
 
+    // DO NOT REMOVE THIS TEST
+    // Motivation: this test checks start/stop correctness
+    // of TarantoolControl class which is used by other tests.
+    // This test is commented out because the class is used
+    // for internal purposes only and isn't related to
+    // the connector testing.
+    //    @Test
+    //    @DisplayName("follow up the issue #164")
+    //    void testStartStopTarantoolInstance() throws InterruptedException {
+    //        int numberOfParallelInstances = 4;
+    //        CountDownLatch finished = new CountDownLatch(numberOfParallelInstances);
+    //        List<String> instancesNames = new ArrayList<>(numberOfParallelInstances);
+    //
+    //        for (int i = 0; i < numberOfParallelInstances; i++) {
+    //            String instance = "startStop" + (i + 1);
+    //            instancesNames.add(instance);
+    //            control.createInstance(
+    //                instancesNames.get(i),
+    //                LUA_FILE,
+    //                makeInstanceEnv(3301 + i + 1, 3321 + i + 1)
+    //            );
+    //            startTarantool(instancesNames.get(i));
+    //            new Thread(() -> {
+    //                for (int j = 0; j < 100; j++) {
+    //                    stopTarantool(instance);
+    //                    startTarantool(instance);
+    //                    if (j % 10 == 0) {
+    //                        System.out.println(
+    //                            Thread.currentThread().getName() + ": " + j + "% completed"
+    //                        );
+    //                    }
+    //                }
+    //                finished.countDown();
+    //            }, "Thread" + i).start();
+    //        }
+    //
+    //        assertTrue(finished.await(2, TimeUnit.MINUTES));
+    //
+    //        for (int i = 0; i < numberOfParallelInstances; i++) {
+    //            stopTarantool(instancesNames.get(i));
+    //        }
+    //    }
+
     /**
      * Test concurrent operations, reconnects and close.
-     *
+     * <p>
      * Expected situation is nothing gets stuck.
-     *
+     * <p>
      * The test sets SO_LINGER to 0 for outgoing connections to avoid producing
      * many TIME_WAIT sockets, because an available port range can be
      * exhausted.
@@ -317,7 +361,7 @@ public void run() {
      * Verify that we don't exceed a file descriptor limit (and so likely don't
      * leak file descriptors) when trying to connect to an existing node with
      * wrong authentification credentials.
-     *
+     * <p>
      * The test sets SO_LINGER to 0 for outgoing connections to avoid producing
      * many TIME_WAIT sockets, because an available port range can be
      * exhausted.
@@ -355,4 +399,5 @@ public void execute() throws Throwable {
         client.syncOps().ping();
         client.close();
     }
+
 }