Skip to content

Commit 0e65e2a

Browse files
committed
Fix false positive internal error detection
Tests are dispatched to task queue dispatchers at start and so it is normal that tests can be not consumed when a test fails in non-force mode or when a test hung. It is not test-run error. The problem part with a failed (not hung) test was introduced in d8abc03 ('Fail testing when test-run fails internally'). Reported in #159 (comment)
1 parent f6c2cc2 commit 0e65e2a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test-run.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ def main_loop_parallel():
107107
dispatcher.wait_processes()
108108
color_stdout('-' * 81, "\n", schema='separator')
109109
has_failed = dispatcher.statistics.print_statistics()
110-
has_undone = dispatcher.report_undone(verbose=True)
110+
has_undone = dispatcher.report_undone(
111+
verbose=bool(is_force or not has_failed))
111112
if has_failed:
112113
return EXIT_FAILED_TEST
113114
if has_undone:
@@ -120,7 +121,7 @@ def main_loop_parallel():
120121
except HangError:
121122
color_stdout('-' * 81, "\n", schema='separator')
122123
dispatcher.statistics.print_statistics()
123-
dispatcher.report_undone(verbose=True)
124+
dispatcher.report_undone(verbose=False)
124125
return EXIT_HANG
125126
return EXIT_SUCCESS
126127

0 commit comments

Comments
 (0)