Skip to content

Commit 6e278b6

Browse files
committed
Fix killing of servers at crash
We should not try to kill non-default servers that was not started yet. Before this commit the following exception can occur. | [001] Test.run() received the following error: | [001] Traceback (most recent call last): | [001] File "/home/alex/projects/tarantool-meta/tarantool/test-run/lib/test.py", line 180, in run | [001] self.execute(server) | [001] File "/home/alex/projects/tarantool-meta/tarantool/test-run/lib/tarantool_server.py", line 154, in execute | [001] self.killall_servers(server, ts, crash_occured) | [001] File "/home/alex/projects/tarantool-meta/tarantool/test-run/lib/tarantool_server.py", line 108, in killall_servers | [001] bad_returncode = server.process.returncode not in (None, | [001] AttributeError: 'TarantoolServer' object has no attribute 'process'
1 parent e4a83a4 commit 6e278b6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/tarantool_server.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ def send_command(command):
101101
def killall_servers(self, server, ts, crash_occured):
102102
""" kill all servers and crash detectors before stream swap """
103103
color_log('Kill all servers ...\n', schema='info')
104-
check_list = ts.servers.values() + [server, ]
104+
server_list = ts.servers.values() + [server, ]
105+
check_list = [s for s in server_list if 'process' in s.__dict__]
105106

106107
# check that all servers stopped correctly
107108
for server in check_list:

0 commit comments

Comments
 (0)