Allow to use unix socket for non-default servers

It allows to mitigate the error 'Address already in use' while binding
admin (console) port. Check [1] for more information (see comment
itself, the issue is about the another problem).

Unified boolean suite.ini options parsing.

[1]: #115 (comment)

Author: Totktonada

lib/preprocessor.py

@@ -211,6 +211,7 @@ def server_create(self, ctype, sname, opts):
         if 'rpl_master' in opts:
             temp.rpl_master = self.servers[opts['rpl_master']]
         temp.vardir = self.suite_ini['vardir']
+        temp.use_unix_sockets = self.suite_ini['use_unix_sockets']
         temp.inspector_port = int(self.suite_ini.get(
             'inspector_port', temp.DEFAULT_INSPECTOR
         ))

lib/tarantool_server.py

@@ -514,7 +514,9 @@ def install(self, silent=True):
         self.copy_files()
 
         if self.use_unix_sockets:
-            self._admin = os.path.join(self.vardir, "socket-admin")
+            path = os.path.join(self.vardir, self.name + ".socket-admin")
+            warn_unix_socket(path)
+            self._admin = path
         else:
             self._admin = find_port()
 

lib/test_suite.py

@@ -61,6 +61,19 @@ def get_multirun_params(self, test_path):
         result = self.multi_run.get('*', None)
         return result
 
+    def parse_bool_opt(self, name, default):
+        val = self.ini.get(name)
+        if val is None:
+            self.ini[name] = default
+        elif isinstance(val, bool):
+            pass
+        elif isinstance(val, str) and val.lower() in ('true', 'false'):
+            # If value is not boolean it come from ini file, need to convert
+            # string 'True' or 'False' into boolean representation.
+            self.ini[name] = val.lower() == 'true'
+        else:
+            raise ConfigurationError(name, val, "'True' or 'False'")
+
     def __init__(self, suite_path, args):
         """Initialize a test suite: check that it exists and contains
         a syntactically correct configuration file. Then create
@@ -97,8 +110,9 @@ def __init__(self, suite_path, args):
                 dict.fromkeys(self.ini[i].split())
                 if i in self.ini else dict())
 
-        self.ini.update(
-            dict(show_reproduce_content=self.show_reproduce_content()))
+        self.parse_bool_opt('use_unix_sockets', False)
+        self.parse_bool_opt('is_parallel', False)
+        self.parse_bool_opt('show_reproduce_content', False)
 
     def find_tests(self):
         if self.ini['core'] == 'tarantool':
@@ -201,23 +215,7 @@ def run_test(self, test, server, inspector):
         return short_status
 
     def is_parallel(self):
-        val = self.ini.get('is_parallel', 'false')
-        if isinstance(val, bool):
-            return val
-        # If value is not boolean it come from ini file, need to
-        # convert string 'True' or 'False' into boolean representation
-        if val.lower() not in ['true', 'false']:
-            raise ConfigurationError('is_parallel', val, "'True' or 'False'")
-        return val.lower() == 'true'
+        return self.ini['is_parallel']
 
     def show_reproduce_content(self):
-        val = self.ini.get('show_reproduce_content', 'true')
-        if isinstance(val, bool):
-            return val
-        # If value is not boolean it come from ini file, need to
-        # convert string 'True' or 'False' into boolean representation
-        if val.lower() not in ['true', 'false']:
-            raise ConfigurationError('show_reproduce_content',
-                                     val,
-                                     "'True' or 'False'")
-        return val.lower() == 'true'
+        return self.ini['show_reproduce_content']