Skip to content

Rewrite all tests using luatest framework #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serpentian opened this issue Aug 26, 2022 · 2 comments
Open

Rewrite all tests using luatest framework #371

Serpentian opened this issue Aug 26, 2022 · 2 comments
Assignees
Labels
blocked Not ready to be implemented qa refactoring Code refactoring teamS Scaling

Comments

@Serpentian
Copy link
Collaborator

Serpentian commented Aug 26, 2022

Currently a lot of tests are written using diff style. Let's port them to luatest.

Here're motivation points of doing this:

  1. We need to develop the vshard's testing infrastructure for luatest.
  2. Diff tests require a lot of code duplication.
  3. Core readability is better for luatest tests.

This will dramatically decrease the time needed to write tests in the future.

@Serpentian Serpentian added qa refactoring Code refactoring teamS Scaling labels Aug 26, 2022
@Serpentian Serpentian self-assigned this Aug 26, 2022
@Serpentian
Copy link
Collaborator Author

Blocked by #107. Cannot test background fibers without manual grepping of logs until issue 107 is solved.

@Serpentian Serpentian added the blocked Not ready to be implemented label Aug 26, 2022
@Serpentian
Copy link
Collaborator Author

I don't think we should port tap tests to luatest, as first ones work much faster, doesn't require any infrastructure, which could be useful for us in the future, and their code is easy to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Not ready to be implemented qa refactoring Code refactoring teamS Scaling
Projects
None yet
Development

No branches or pull requests

1 participant