Skip to content

Commit ca4db8a

Browse files
tatuttatut
committed
Update test suite
1 parent fa1dc79 commit ca4db8a

File tree

5 files changed

+79
-61
lines changed

5 files changed

+79
-61
lines changed

‎project.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
(defproject webjure/json-schema "0.7.4"
2-
:description "Minimalistic JSON schema validator with $ref support."
1+
(defproject webjure/json-schema "20180613-SNAPSHOT"
2+
:description "JSON schema validator"
33
:url "https://github.com/tatut/json-schema"
44
:license {:name "MIT License"
55
:url "http://www.opensource.org/licenses/mit-license.php"}

‎src/webjure/json_schema/validator.clj

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -302,18 +302,19 @@
302302

303303
;; Schema is an array, validate each index with its own schema
304304
(sequential? item-schema)
305-
(or (and (< c (count item-schema))
305+
(or #_(and (< c (count item-schema))
306306
{:error :too-few-items
307307
:expected-item-count (count item-schema)
308308
:actual-item-count c
309309
:data data})
310310

311311
(first
312-
(for [i (range (count item-schema))
313-
:let [item (nth data i)
314-
e (validate (nth item-schema i) item options)]
315-
:when e]
316-
e))
312+
(let [items (count data)]
313+
(for [i (range (count item-schema))
314+
:let [e (when (> items i)
315+
(validate (nth item-schema i) (nth data i) options))]
316+
:when e]
317+
e)))
317318

318319
;; If additional items is false, don't allow more items
319320
(and (false? additional-items)
@@ -388,10 +389,12 @@
388389
"Validate match against any of the given schemas."
389390
[{any-of "anyOf"} data options]
390391
(when-not (empty? any-of)
391-
(when-not (some #(nil? (validate % data options)) any-of)
392-
{:error :does-not-match-any-of
393-
:any-of any-of
394-
:data data})))
392+
(let [errors (mapv #(validate % data options) any-of)]
393+
(when-not (some nil? errors)
394+
{:error :does-not-match-any-of
395+
:any-of any-of
396+
:data data
397+
:errors errors}))))
395398

396399
(defn validate-one-of
397400
"Validate match against one (and only one) of the given schemas."

‎src/webjure/json_schema/validator/format.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060

6161
(defn validate-uri [d]
6262
(let [d (str d)]
63-
(if-not (and (.contains d "/")
63+
(if-not (and (.contains d ":")
6464
(try
6565
(java.net.URI. d)
6666
true

‎src/webjure/json_schema/validator/macro.clj

Lines changed: 43 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156

157157

158158

159-
(defn validate-string-format [{format "format"} data error ok
159+
(defn validate-string-format [{format "format" :as schema} data error ok
160160
{lax-date-time-format? :lax-date-time-format?}]
161161
(when format
162162
(let [e (gensym "E")]
@@ -171,7 +171,7 @@
171171
"uri" 'webjure.json-schema.validator.format/validate-uri
172172
"email" 'webjure.json-schema.validator.format/validate-email
173173
(do
174-
(println "WARNING: Unsupported format: " format)
174+
(println "WARNING: Unsupported format: " format " in schema: " schema)
175175
`(constantly nil)))
176176
~data))]
177177
~(error e)
@@ -337,6 +337,7 @@
337337
additional-items "additionalItems" :as schema} data error ok options]
338338
(when item-schema
339339
(let [e (gensym "E")
340+
c (gensym "C")
340341
item (gensym "ITEM")
341342
item-error (gensym "ITEM-ERROR")]
342343
`(if-not (sequential? ~data)
@@ -370,35 +371,37 @@
370371

371372
;; Schema is an array, validate each index with its own schema
372373
(sequential? item-schema)
373-
`(if-let [~e (or
374-
(when (< (count ~data) ~(count item-schema))
375-
{:error :too-few-items
376-
:expected-item-count ~(count item-schema)
377-
:actual-item-count (count ~data)
378-
:data ~data})
379-
380-
~@(for [i (range (count item-schema))]
381-
`(let [~item (nth ~data ~i)]
382-
~(validate (nth item-schema i) item options)))
383-
384-
;; If additional items is false, don't allow more items
385-
~@(when (false? additional-items)
386-
[`(when (> (count ~data) ~(count item-schema))
387-
{:error :additional-items-not-allowed
388-
:additional-items (drop ~(count item-schema) ~data)
389-
:data ~data})])
390-
391-
;; If additional items is a schema, check each against it
392-
~@(when (map? additional-items)
393-
[`(some (fn [~item]
394-
(when-let [e# ~(validate additional-items item options)]
395-
{:error :additional-item-does-not-match-schema
396-
:item-error e#
397-
:data ~data}))
398-
(drop ~(count item-schema) ~data))])
399-
)]
400-
~(error e)
401-
~(ok)))))))
374+
`(let [~c (count ~data)]
375+
(if-let [~e (or
376+
#_(when (< (count ~data) ~(count item-schema))
377+
{:error :too-few-items
378+
:expected-item-count ~(count item-schema)
379+
:actual-item-count (count ~data)
380+
:data ~data})
381+
382+
~@(for [i (range (count item-schema))]
383+
`(when (> ~c ~i)
384+
(let [~item (nth ~data ~i)]
385+
~(validate (nth item-schema i) item options))))
386+
387+
;; If additional items is false, don't allow more items
388+
~@(when (false? additional-items)
389+
[`(when (> ~c ~(count item-schema))
390+
{:error :additional-items-not-allowed
391+
:additional-items (drop ~(count item-schema) ~data)
392+
:data ~data})])
393+
394+
;; If additional items is a schema, check each against it
395+
~@(when (map? additional-items)
396+
[`(some (fn [~item]
397+
(when-let [e# ~(validate additional-items item options)]
398+
{:error :additional-item-does-not-match-schema
399+
:item-error e#
400+
:data ~data}))
401+
(drop ~(count item-schema) ~data))])
402+
)]
403+
~(error e)
404+
~(ok))))))))
402405

403406
(defn validate-array-item-count [{min-items "minItems" max-items "maxItems"} data error ok options]
404407
(when (or min-items max-items)
@@ -477,14 +480,15 @@
477480
[{any-of "anyOf"} data error ok options]
478481
(when-not (empty? any-of)
479482
(let [e (gensym "E")]
480-
`(if-not (or
481-
~@(for [schema any-of]
482-
`(nil? ~(validate schema data options))))
483-
(let [~e {:error :does-not-match-any-of
484-
:any-of ~any-of
485-
:data ~data}]
486-
~(error e))
487-
~(ok)))))
483+
`(let [errors# [~@(for [schema any-of]
484+
(validate schema data options))]]
485+
(if (some nil? errors#)
486+
~(ok)
487+
(let [~e {:error :does-not-match-any-of
488+
:any-of ~any-of
489+
:data ~data
490+
:errors errors#}]
491+
~(error e)))))))
488492

489493
(defn validate-one-of
490494
"Validate match against one (and only one) of the given schemas."

‎test/webjure/json_schema/suite_test.clj

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,22 @@
2020
;; Skip recursive schema in the macro version as it
2121
;; creates an ever expanding function (causing a stack overflow)
2222
"ref" {"root pointer ref" {:macro false}
23-
"remote ref, containing refs itself" {:macro false}}
23+
"remote ref, containing refs itself" {:macro false}
24+
"Recursive references between schemas" {:skip true}
25+
:options {:ref-resolver ref-resolver}}
26+
27+
;; We don't have a regex for a regex
28+
"ecmascript-regex" {:skip true}
2429

2530
;; Cheat (a little bit) here, change http URLs to file URIs so that
2631
;; we don't need to start an HTTP server. Clojure slurp works for
2732
;; both URI types the same.
28-
"refRemote" {:options {:ref-resolver ref-resolver}}
33+
"refRemote" {"base URI change - change folder" {:skip true}
34+
"base URI change - change folder in subschema" {:skip true}
35+
"root ref in remote ref" {:skip true}
36+
:options {:ref-resolver ref-resolver}}
37+
38+
"format" {"validation of date-time strings" {"a valid date-time string without second fraction" {:skip true}}}
2939
})
3040

3141
(def suite-tests
@@ -44,24 +54,25 @@
4454
(let [schema-sym (gensym "SCHEMA")]
4555
`(do
4656
~@(for [[test-name tests] suite-tests
47-
:let [options (or (get-in exclusions [test-name :options]))]
57+
:let [options (or (get-in exclusions [test-name :options]) {})]
4858
:when (not (:skip (exclusions test-name)))]
4959
`(deftest ~(sym (str "suite-" test-name))
5060
~@(for [{desc "description"
5161
schema "schema"
5262
tests "tests"} tests
53-
:let [schema (ref/initialize-id-path schema)]
63+
:let [schema (ref/initialize-id-path schema)
64+
options (merge options (get-in exclusions [test-name desc :options]))]
5465
:when (not (:skip (get-in exclusions [test-name desc])))]
5566
`(testing ~desc
5667
(let [~schema-sym (validate-fn ~schema ~options ~(get-in exclusions [test-name desc]))]
57-
~@(for [{desc "description"
68+
~@(for [{test-desc "description"
5869
data "data"
59-
valid? "valid"} tests]
70+
valid? "valid"} tests
71+
:when (not (:skip (get-in exclusions [test-name desc test-desc])))]
6072
(if valid?
6173
`(is (nil? (~schema-sym ~data))
62-
~(str "Test '" desc "' should be valid"))
74+
~(str "Test '" test-desc "' should be valid"))
6375
`(is (~schema-sym ~data)
64-
~(str "Test '" desc "' should NOT be valid"))))))))))))
65-
76+
~(str "Test '" test-desc "' should NOT be valid"))))))))))))
6677

6778
(define-suite-tests)

0 commit comments

Comments
 (0)