Drop support for node 4 and 5. Require npm-package-json-lint 3.x.x (#5)

* Drop support for node 4 and 5. Require npm-package-json-lint 3.x.x

* Bump to 3.0.0

* Update cli command

* Update tests to use new v3 api

* Pass only rules

* typo 👎

* check error count

* issues.length

Author: tclindner

.travis.yml

@@ -10,12 +10,11 @@ sudo: false
 language: node_js
 
 node_js:
-  - "4"
-  - "5"
   - "6"
   - "7"
   - "8"
   - "9"
+  - "10"
 
 cache:
   directories:

CHANGELOG.md

@@ -12,6 +12,13 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Removed
 
 
+## [2.0.0] - 2018-05-09
+### Changed
+- Bump dependencies and require npm-package-json-lint 3.x.x
+
+### Removed
+- Dropped support for Node 4 and 5.
+
 ## [1.1.0] - 2017-08-02
 ### Changed
 - Bump dependencies

CONTRIBUTING.md

@@ -4,8 +4,8 @@
 
 ### Node
 
-* [Node.js](https://nodejs.org/) - v4.2.0+
-* [npm](https://www.npmjs.com/) - v2.14.7+
+* [Node.js](https://nodejs.org/) - v6.0.0+
+* [npm](https://www.npmjs.com/) - v3.0.0+
 
 ## Install project dependencies
 

README.md

@@ -22,8 +22,8 @@ First thing first, let's make sure you have the necessary pre-requisites.
 
 #### Node
 
-* [Node.js](https://nodejs.org/) - v4.2.0+
-* [npm](http://npmjs.com) - v2.14.7+
+* [Node.js](https://nodejs.org/) - v6.0.0+
+* [npm](http://npmjs.com) - v3.0.0+
 
 ### Command
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "npm-package-json-lint-config-tc",
-  "version": "1.1.0",
+  "version": "2.0.0",
   "description": "npm-package-json-lint shareable config for TC's projects",
   "keywords": [
     "lint",
@@ -24,28 +24,26 @@
   "main": "index.js",
   "scripts": {
     "eslint": "eslint *.js --format=node_modules/eslint-formatter-pretty",
-    "jsonlint": "jsonlint *.json",
-    "lint": "npm run npmpackagejsonlint && npm run eslint && npm run jsonlint",
-    "npmpackagejsonlint": "pjl-cli -c .npmpackagejsonlintrc.json",
+    "lint": "npm run npmpackagejsonlint && npm run eslint",
+    "npmpackagejsonlint": "npmPkgJsonLint .",
     "test": "mocha"
   },
   "devDependencies": {
     "chai": "^4.1.2",
-    "eslint": "^4.10.0",
-    "eslint-config-tc": "^2.2.0",
+    "eslint": "^4.19.1",
+    "eslint-config-tc": "^2.4.0",
     "eslint-formatter-pretty": "^1.3.0",
     "is-plain-obj": "^1.1.0",
-    "jsonlint": "^1.6.2",
-    "mocha": "^4.0.1",
-    "npm-package-json-lint": "^2.11.0",
-    "temp-write": "^3.3.0"
+    "mocha": "^5.1.1",
+    "npm-package-json-lint": "^3.0.0",
+    "temp-write": "^3.4.0"
   },
   "peerDependencies": {
-    "npm-package-json-lint": ">= 2"
+    "npm-package-json-lint": ">= 3"
   },
   "engines": {
-    "node": ">=4.2.0",
-    "npm": ">=2.14.7"
+    "node": ">=6.0.0",
+    "npm": ">=3.0.0"
   },
   "license": "MIT"
 }

test/helper/testHelper.js

@@ -1,12 +1,9 @@
 'use strict';
 
-const NpmPackageJsonLint = require('npm-package-json-lint');
+const NpmPackageJsonLint = require('npm-package-json-lint').NpmPackageJsonLint;
 
 module.exports = function lint(packageJsonData, config) {
-  const options = {
-    ignoreWarnings: true
-  };
-  const npmPackageJsonLint = new NpmPackageJsonLint(packageJsonData, config, options);
+  const npmPackageJsonLint = new NpmPackageJsonLint();
 
-  return npmPackageJsonLint.lint();
+  return npmPackageJsonLint.lint(packageJsonData, config);
 };

test/tests.js

@@ -25,10 +25,10 @@ describe('npm-package-json-lint config tests', () => {
       const packageJsonData = {
         author: 'Caitlin Snow'
       };
-      const results = lint(packageJsonData, config);
+      const results = lint(packageJsonData, config.rules);
       const expectedErrorCount = 14;
 
-      results.errors.length.should.equal(expectedErrorCount);
+      results.issues.length.should.equal(expectedErrorCount);
       results.hasOwnProperty('warnings').should.be.false;
     });
   });