Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Commit 9f5a60e

Browse files
Kristian D. DimitrovKristianDD
Kristian D. Dimitrov
authored andcommitted
Fix searching for devices for both platforms on Mac when platform specified.
1 parent 7d1d1b5 commit 9f5a60e

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

mobile/mobile-core/devices-service.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
174174

175175
for (const deviceDiscovery of this._allDeviceDiscoveries) {
176176
try {
177-
await deviceDiscovery.startLookingForDevices();
177+
await deviceDiscovery.startLookingForDevices({ shouldReturnImmediateResult: false, platform: this._platform });
178178
} catch (err) {
179179
this.$logger.trace("Error while checking for new devices.", err);
180180
}
@@ -219,15 +219,18 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
219219
*/
220220
private async startLookingForDevices(options?: Mobile.IDeviceLookingOptions): Promise<void> {
221221
this.$logger.trace("startLookingForDevices; platform is %s", this._platform);
222+
if (!options) {
223+
options = {shouldReturnImmediateResult: false, platform: this._platform};
224+
}
222225
if (!this._platform) {
223226
await this.detectCurrentlyAttachedDevices(options);
224227
await this.startDeviceDetectionInterval();
225228
} else {
226229
if (this.$mobileHelper.isiOSPlatform(this._platform)) {
227-
await this.$iOSDeviceDiscovery.startLookingForDevices();
228-
await this.$iOSSimulatorDiscovery.startLookingForDevices();
230+
await this.$iOSDeviceDiscovery.startLookingForDevices(options);
231+
await this.$iOSSimulatorDiscovery.startLookingForDevices(options);
229232
} else if (this.$mobileHelper.isAndroidPlatform(this._platform)) {
230-
await this.$androidDeviceDiscovery.startLookingForDevices();
233+
await this.$androidDeviceDiscovery.startLookingForDevices(options);
231234
}
232235

233236
for (const deviceDiscovery of this._otherDeviceDiscoveries) {
@@ -606,9 +609,9 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
606609
await emulatorServices.startEmulator(emulatorImage);
607610

608611
if (this.$mobileHelper.isAndroidPlatform(platform)) {
609-
await this.$androidDeviceDiscovery.startLookingForDevices();
612+
await this.$androidDeviceDiscovery.startLookingForDevices({ shouldReturnImmediateResult: false, platform: platform });
610613
} else if (this.$mobileHelper.isiOSPlatform(platform) && this.$hostInfo.isDarwin) {
611-
await this.$iOSSimulatorDiscovery.startLookingForDevices();
614+
await this.$iOSSimulatorDiscovery.startLookingForDevices({ shouldReturnImmediateResult: false, platform: platform });
612615
}
613616
}
614617

0 commit comments

Comments
 (0)