-
Notifications
You must be signed in to change notification settings - Fork 614
Publish developer docker containers on dockerhub #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In the long term, we should push the build cache in dockerhub (or some other registry) in the master branch, and then we would be able to reuse the cache in other build or even locally. This is enabled by the docker buildx option --cache-from and --cache-to. Buildx should be included in docker at some point ( see moby/moby#40379) but I'm unsure of the timeline. So an option might be to just provide a remote docker cache for users to make sure they always work with an up to date image. But pushing a docker image is easy too and shouldn't cause any issues too so we can do both and then users don't need to About the docker remote caching, I experimented with it a while ago and it seemed too slow (like actually slower than pulling a docker image, that makes no sense). I hope it gets better in the future. |
In Tensorflow see also tensorflow/tensorflow#38755 |
Friendly bump @karmel on this issue brought up here: Would it be possible for us to push a developer image to the |
Ah, sorry for the delay. It sounds like this is technically possible, but we need a policy and someone to review the pushes. @ewilderj @theadactyl -- are you able to help here? |
Just as a reminder when we will have the developer image I think that we need to refactor the pre-commit hooks cause we will not want to run Docker in Docker just for linting and all the linting tools will be already available in the Dev image. |
See #1309
The text was updated successfully, but these errors were encountered: