Skip to content

Remove OpenEXR from requirements and warning #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonas-eschle opened this issue Jul 11, 2020 · 2 comments
Open

Remove OpenEXR from requirements and warning #421

jonas-eschle opened this issue Jul 11, 2020 · 2 comments

Comments

@jonas-eschle
Copy link

The docs and code say that OpenEXR is an optional dependency (

or here but is seemingly is not. This means I cannot install the TFG package, since the OpenEXR does not get installed properly. Furthermore, the warning is rather annoying, as we would like to use some simple functionality from the package (bsplines) in a completely different context.

I would propose to
a) remove OpenEXR from the dependency list and make it optional (as documented in docs and code)
b) remove the warning and instead make OpenEXR a local import inside the function. If the function is called and it cannot be imported, it fails saying that it has to install OpenEXR first.

What do you think? Glad also to make this changes and contribute

@atyshka
Copy link

atyshka commented Sep 22, 2020

+1 on this, having to build an unwanted dependency from source is a burden

@jonas-eschle
Copy link
Author

Is there any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jonas-eschle @atyshka and others