Updated example with multiple SANs after PR #32

Author: antonbabenko

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 - repo: git://github.com/antonbabenko/pre-commit-terraform
-  rev: v1.20.0
+  rev: v1.21.0
   hooks:
     - id: terraform_fmt
     - id: terraform_docs

examples/complete-dns-validation/README.md

@@ -19,12 +19,6 @@ $ terraform apply
 Note that this example may create resources which cost money. Run `terraform destroy` when you don't need these resources.
 
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
-## Inputs
-
-| Name | Description | Type | Default | Required |
-|------|-------------|:----:|:-----:|:-----:|
-| domain\_name | Domain name to use as Route53 zone and ACM certificate | string | `"my-domain-name.com"` | no |
-
 ## Outputs
 
 | Name | Description |

examples/complete-dns-validation/main.tf

@@ -1,26 +1,42 @@
-variable "domain_name" {
-  description = "Domain name to use as Route53 zone and ACM certificate"
-  default     = "my-domain-name.com"
+locals {
+  # Use existing (via data source) or create new zone (will fail validation, if zone is not reachable)
+  use_existing_route53_zone = true
+
+  domain = "terraform-aws-modules.modules.tf"
+
+  # Removing trailing dot from domain - just to be sure :)
+  domain_name = trimsuffix(local.domain, ".")
+}
+
+data "aws_route53_zone" "this" {
+  count = local.use_existing_route53_zone ? 1 : 0
+
+  name         = local.domain_name
+  private_zone = false
 }
 
 resource "aws_route53_zone" "this" {
-  name = var.domain_name
+  count = ! local.use_existing_route53_zone ? 1 : 0
+  name  = local.domain_name
 }
 
 module "acm" {
   source = "../../"
 
-  domain_name = var.domain_name
-  zone_id     = aws_route53_zone.this.zone_id
+  domain_name = local.domain_name
+  zone_id     = coalescelist(data.aws_route53_zone.this.*.zone_id, aws_route53_zone.this.*.zone_id)[0]
 
   subject_alternative_names = [
-    "*.${var.domain_name}",
-    "new.sub.${var.domain_name}",
+    "*.alerts.${local.domain_name}",
+    "*.something.${local.domain_name}",
+    "*.news.${local.domain_name}",
+    "*.info.${local.domain_name}",
+    "new.sub.${local.domain_name}",
   ]
 
-  wait_for_validation = false # true
+  wait_for_validation = true
 
   tags = {
-    Name = var.domain_name
+    Name = local.domain_name
   }
 }

main.tf

@@ -21,7 +21,7 @@ resource "aws_acm_certificate" "this" {
 }
 
 resource "aws_route53_record" "validation" {
-  count = var.create_certificate && var.validation_method == "DNS" && var.validate_certificate ? length(local.distinct_domain_names)+1 : 0
+  count = var.create_certificate && var.validation_method == "DNS" && var.validate_certificate ? length(local.distinct_domain_names) + 1 : 0
 
   zone_id = var.zone_id
   name    = element(local.validation_domains, count.index)["resource_record_name"]