fix(kafka): Add redpanda testcontainer module #441
Conversation
There was a problem hiding this comment.
because it's a stand-in for kafka, I'd rather have you implement this in the kafka module instead of a completely new module. At that point it isn't about "what the container is" but what the developer experience looks like.
I have no issues with from testcontainers.kafka import KafkaContainer, RedpandaContainer 🙏
In fact it would be interesting to see if you can devise a common interface from them - that would help devs choose more easily.
pyproject.toml
Outdated
| psycopg2-binary = { version = "*", optional = true } | ||
| pika = { version = "*", optional = true } | ||
| redis = { version = "*", optional = true } | ||
| redpanda = { version = "*", optional = true } |
There was a problem hiding this comment.
The redpanda lib is not what you think it is. https://pypi.org/project/redpanda/ neither is https://pypi.org/project/red-panda/
You won't need either of these since this is a kafka-compliant container. See my overall review!
pyproject.toml
Outdated
| postgres = ["sqlalchemy", "psycopg2-binary"] | ||
| rabbitmq = ["pika"] | ||
| redis = ["redis"] | ||
| redpanda = [] |
There was a problem hiding this comment.
not needed, move the container into the kafka module instead, please
alexanderankin
changed the title
|
i opened gudjonragnar#2 in the meantime |
alexanderankin
added
the
community-feat
alexanderankin
changed the title
alexanderankin
dismissed
totallyzen’s stale review
requested changes were implemented
|
FYI to all who follow testcontainers-python - the kafka package on pypi is being (temporarily?) published on a different package name, please see the issue dpkp/kafka-python#2431 for more details. |
🤖 I have created a release *beep* *boop* --- ## [4.3.0](testcontainers-v4.2.0...testcontainers-v4.3.0) (2024-04-01) ### Features * **client:** Add custom User-Agent in Docker client as `tc-python/<version>` ([#507](#507)) ([dd55082](dd55082)) ### Bug Fixes * Add CassandraContainer ([#476](#476)) ([507e466](507e466)) * add chroma container ([#515](#515)) ([0729bf4](0729bf4)) * Add Weaviate module ([#492](#492)) ([90762e8](90762e8)) * **cassandra:** make cassandra dependency optional/test-only ([#518](#518)) ([bddbaeb](bddbaeb)) * **core:** allow setting docker command path for docker compose ([#512](#512)) ([63fcd52](63fcd52)) * **google:** add support for Datastore emulator ([#508](#508)) ([3d891a5](3d891a5)) * Improved Oracle DB module ([#363](#363)) ([6e6d8e3](6e6d8e3)) * inconsistent test runs for community modules ([#497](#497)) ([914f1e5](914f1e5)) * **kafka:** Add redpanda testcontainer module ([#441](#441)) ([451d278](451d278)) * **kafka:** wait_for_logs in kafka container to reduce lib requirement ([#377](#377)) ([909107b](909107b)) * **keycloak:** container should use dedicated API endpoints to determine container readiness ([#490](#490)) ([2e27225](2e27225)) * **nats:** Client-Free(ish) NATS container ([#462](#462)) ([302c73d](302c73d)) * **new:** add a new Docker Registry test container ([#389](#389)) ([0f554fb](0f554fb)) * pass doctests, s/doctest/doctests/, run them in gha, s/asyncpg/psycopg/ in doctest, fix keycloak flakiness: wait for first user ([#505](#505)) ([545240d](545240d)) * pass updated keyword args to Publisher/Subscriber client in google/pubsub [#161](#161) ([#164](#164)) ([8addc11](8addc11)) * Qdrant module ([#463](#463)) ([e8876f4](e8876f4)) * remove accidentally added pip in dev dependencies ([#516](#516)) ([dee20a7](dee20a7)) * **ryuk:** Enable Ryuk test suite. Ryuk image 0.5.1 -> 0.7.0. Add RYUK_RECONNECTION_TIMEOUT env variable ([#509](#509)) ([472b2c2](472b2c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.