Skip to content

Cypress test builds broken because latest release of @testing-library/dom (8.18.0) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sneridagh opened this issue Sep 19, 2022 · 1 comment

Comments

@sneridagh
Copy link

  • cypress-testing-library version: 8.0.2
  • node version: 16

Relevant code or config

Reproduction repository: https://github.com/plone/ploneconf.org/actions/runs/3080420601/jobs/4979205093#step:7:138

Problem description: cypress-testing-library has a caret dependency on @testing-library/dom.

https://github.com/testing-library/cypress-testing-library/blob/main/package.json#L44

Latest @testing-library/dom (8.18.0) has a problem in the dist ESM file:

testing-library/dom-testing-library#1169

Therefore, all projects depending on cypress-testing-library will break when they get the latest @testing-library/dom.

@sneridagh
Copy link
Author

Closing as this was fixed in testing-library/dom-testing-library#1169 via testing-library/dom-testing-library#1170, and released: https://www.npmjs.com/package/@testing-library/dom/v/8.18.1

Cypress is meant to Webpack compile import @testing-library/cypress/add-commands for the browser as well, so all its dependencies should be also able to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant