From 49ac60ef489ee9e28364e6d71c7343c1e77c9ccd Mon Sep 17 00:00:00 2001 From: Matan Borenkraout Date: Tue, 5 Sep 2023 09:46:07 +0300 Subject: [PATCH 1/3] feat: Drop support for Node.js 14.x and add support for Node 20.x BREAKING CHANGE: Minimum supported Node.js version is now 14.x --- .github/workflows/validate.yml | 4 ++-- package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 3efc53fe..d1ec79c4 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -26,7 +26,7 @@ jobs: # Otherwise we would not know if the problem is tied to the Node.js version fail-fast: false matrix: - node: [14, 16, 18] + node: [16, 18, 20] runs-on: ubuntu-latest steps: - name: 🛑 Cancel Previous Runs @@ -82,7 +82,7 @@ jobs: - name: ⎔ Setup node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 16 - name: 📥 Download deps uses: bahmutov/npm-install@v1 diff --git a/package.json b/package.json index fd4a11d1..806029e8 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "author": "Kent C. Dodds (https://kentcdodds.com)", "license": "MIT", "engines": { - "node": ">=14" + "node": ">=16" }, "browserslist": [ "and_chr 103", @@ -40,7 +40,7 @@ "safari 15.5", "samsung 17.0", "samsung 16.0", - "node 14.0" + "node 16.0" ], "scripts": { "build": "kcd-scripts build --no-ts-defs --ignore \"**/__tests__/**,**/__node_tests__/**,**/__mocks__/**\" && kcd-scripts build --no-ts-defs --bundle --no-clean", From d2b086ae7fefd5fa49cdc14b7213c6c92665ab2e Mon Sep 17 00:00:00 2001 From: Matan Borenkraout Date: Tue, 5 Sep 2023 09:49:49 +0300 Subject: [PATCH 2/3] update node version in codesandbox --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index e650cd6f..adbf2472 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { "installCommand": "install:csb", "sandboxes": ["github/kentcdodds/react-testing-library-examples"], - "node": "14" + "node": "16" } From 86beed61d8068b245613afddd4673231385a2d4e Mon Sep 17 00:00:00 2001 From: Matan Borenkraout Date: Sat, 9 Sep 2023 22:03:06 +0300 Subject: [PATCH 3/3] drop support for node 16 too --- .codesandbox/ci.json | 2 +- .github/workflows/validate.yml | 4 ++-- package.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index adbf2472..c66df417 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { "installCommand": "install:csb", "sandboxes": ["github/kentcdodds/react-testing-library-examples"], - "node": "16" + "node": "18" } diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 0e38e19a..2a938d48 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -29,7 +29,7 @@ jobs: # Otherwise we would not know if the problem is tied to the Node.js version fail-fast: false matrix: - node: [16, 18, 20] + node: [18, 20] runs-on: ubuntu-latest steps: - name: ⬇️ Checkout repo @@ -78,7 +78,7 @@ jobs: - name: ⎔ Setup node uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - name: 📥 Download deps uses: bahmutov/npm-install@v1 diff --git a/package.json b/package.json index 6a89a4ae..83d2ab26 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "author": "Kent C. Dodds (https://kentcdodds.com)", "license": "MIT", "engines": { - "node": ">=16" + "node": ">=18" }, "browserslist": [ "and_chr 103", @@ -40,7 +40,7 @@ "safari 15.5", "samsung 17.0", "samsung 16.0", - "node 16.0" + "node 18.0" ], "scripts": { "build": "kcd-scripts build --no-ts-defs --ignore \"**/__tests__/**,**/__node_tests__/**,**/__mocks__/**\" && kcd-scripts build --no-ts-defs --bundle --no-clean",