From a920e21b778de4e0ceb5d396d8e2e6f02dcd5c7b Mon Sep 17 00:00:00 2001 From: Bryan Opfer Date: Thu, 11 Apr 2019 21:53:42 -0700 Subject: [PATCH 1/2] Remove Error as a possible return value since errors are thrown --- typings/queries.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/typings/queries.d.ts b/typings/queries.d.ts index 240f454f..2563bc4a 100644 --- a/typings/queries.d.ts +++ b/typings/queries.d.ts @@ -19,7 +19,7 @@ export type FindAllByBoundAttribute = ( id: Matcher, options?: MatcherOptions, waitForElementOptions?: WaitForElementOptions -) => Promise | Error +) => Promise export type GetByBoundAttribute = ( container: HTMLElement, @@ -32,7 +32,7 @@ export type FindByBoundAttribute = ( id: Matcher, options?: MatcherOptions, waitForElementOptions?: WaitForElementOptions -) => Promise | Error +) => Promise export type QueryByText = ( container: HTMLElement, @@ -51,7 +51,7 @@ export type FindAllByText = ( id: Matcher, options?: SelectorMatcherOptions, waitForElementOptions?: WaitForElementOptions -) => Promise | Error +) => Promise export type GetByText = ( container: HTMLElement, @@ -64,7 +64,7 @@ export type FindByText = ( id: Matcher, options?: SelectorMatcherOptions, waitForElementOptions?: WaitForElementOptions -) => Promise | Error +) => Promise export const getByLabelText: GetByText export const getAllByLabelText: AllByText From b221f66c246aa1a7a7ed0f8c6b9b64492bcd34da Mon Sep 17 00:00:00 2001 From: Alex Krolick Date: Fri, 12 Apr 2019 00:03:51 -0700 Subject: [PATCH 2/2] docs: fix a typo to kick the codecov build --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ef6414ca..61a0e04d 100644 --- a/README.md +++ b/README.md @@ -65,7 +65,7 @@ your team down. The `dom-testing-library` is a very light-weight solution for testing DOM nodes (whether simulated with [`JSDOM`](https://github.com/jsdom/jsdom) as provided by -default with [jest][] or in the browser). The main utilities it provides involve +default with [Jest][] or in the browser). The main utilities it provides involve querying the DOM for nodes in a way that's similar to how the user finds elements on the page. In this way, the library helps ensure your tests give you confidence in your UI code. The `dom-testing-library`'s primary guiding