Skip to content

Commit 369e24f

Browse files
authored
fix(prefer-find-by): avoid reporting querySelector (#538)
* fix(prefer-find-by): fix report with querySelector Fix #501 * fixup! fix(prefer-find-by): fix report with querySelector
1 parent a6d4cda commit 369e24f

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

lib/rules/prefer-find-by.ts

+4
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
373373
const callArguments = getQueryArguments(argument.body);
374374
const queryMethod = fullQueryMethod.split('By')[1];
375375

376+
if (!queryMethod) {
377+
return;
378+
}
379+
376380
reportInvalidUsage(node, {
377381
queryMethod,
378382
queryVariant,

tests/lib/rules/prefer-find-by.test.ts

+17
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,23 @@ ruleTester.run(RULE_NAME, rule, {
149149
})
150150
`,
151151
},
152+
{
153+
code: `
154+
import {screen, waitFor} from '@testing-library/foo';
155+
it('tests', async () => {
156+
await waitFor(() => expect(screen.querySelector('baz')).toBeInTheDocument());
157+
})
158+
`,
159+
},
160+
{
161+
code: `
162+
import {waitFor} from '@testing-library/foo';
163+
it('tests', async () => {
164+
const { container } = render()
165+
await waitFor(() => expect(container.querySelector('baz')).toBeInTheDocument());
166+
})
167+
`,
168+
},
152169
],
153170
invalid: [
154171
...createScenario((waitMethod: string, queryMethod: string) => ({

0 commit comments

Comments
 (0)