fix(prefer-screen-queries): false positives when using within method

Author: unknown

docs/rules/prefer-screen-queries.md

@@ -23,6 +23,9 @@ import { screen } from '@testing-library/any-framework';
 
 render(<Component />);
 screen.getByText('foo');
+
+// using after within clause
+within(screen.getByTestId('section')).getByText('foo');
 ```
 
 ## Further Reading

lib/rules/prefer-screen-queries.js

@@ -34,7 +34,23 @@ module.exports = {
 
     return {
       [`CallExpression > Identifier[name=/^${ALL_QUERIES_COMBINATIONS_REGEXP}$/]`]: reportInvalidUsage,
-      [`MemberExpression[object.name!="screen"] > Identifier[name=/^${ALL_QUERIES_COMBINATIONS_REGEXP}$/]`]: reportInvalidUsage,
+      [`MemberExpression > Identifier[name=/^${ALL_QUERIES_COMBINATIONS_REGEXP}$/]`](
+        node
+      ) {
+        if (
+          node.parent.object.type === 'CallExpression' &&
+          node.parent.object.callee.name !== 'within'
+        ) {
+          reportInvalidUsage(node);
+          return;
+        }
+        if (
+          node.parent.object.type === 'Identifier' &&
+          node.parent.object.name !== 'screen'
+        ) {
+          reportInvalidUsage(node);
+        }
+      },
     };
   },
 };

tests/lib/rules/prefer-screen-queries.js

@@ -20,6 +20,12 @@ ruleTester.run('prefer-screen-queries', rule, {
     {
       code: `component.otherFunctionShouldNotThrow()`,
     },
+    ...ALL_QUERIES_COMBINATIONS.map(queryMethod => ({
+      code: `within(component).${queryMethod}()`,
+    })),
+    ...ALL_QUERIES_COMBINATIONS.map(queryMethod => ({
+      code: `within(screen.${queryMethod}()).${queryMethod}()`,
+    })),
   ],
 
   invalid: [