Skip to content

Commit 9e4d311

Browse files
committed
chore: review changes
1 parent a00d01a commit 9e4d311

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

docs/rules/no-promise-in-fire-event.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ fireEvent.click(screen.getByRole('button'));
2424

2525
// use awaited findBy queries
2626
fireEvent.click(await screen.findByRole('button'));
27+
28+
// this won't give a linting error, but it will throw a runtime error
29+
const promise = new Promise();
30+
fireEvent.click(promise)`,
2731
```
2832

2933
## Further Reading

tests/lib/rules/no-promise-in-fire-event.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ ruleTester.run(RULE_NAME, rule, {
3131
code: `
3232
import {fireEvent} from '@testing-library/foo';
3333
34+
const promise = new Promise();
3435
fireEvent.click(promise)`,
3536
},
3637
{

0 commit comments

Comments
 (0)