feat(prefer-query-by-disappearance): add to all configs by default (#487)

BREAKING CHANGE: `prefer-query-by-disappearance` is now enabled by default in all configs

Author: MichaelDeBoey

README.md

@@ -209,7 +209,7 @@ To enable this configuration use the `extends` property in your
 | [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md)                   | Suggest using explicit assertions rather than standalone queries                             |     |                                                                   |
 | [`testing-library/prefer-find-by`](./docs/rules/prefer-find-by.md)                                   | Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements | 🔧  | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
 | [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md)                 | Ensure appropriate `get*`/`query*` queries are used with their respective matchers           |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
-| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md)     | Suggest using `queryBy*` queries when waiting for disappearance                              |     |                                                                   |
+| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md)     | Suggest using `queryBy*` queries when waiting for disappearance                              |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
 | [`testing-library/prefer-screen-queries`](./docs/rules/prefer-screen-queries.md)                     | Suggest using `screen` while querying                                                        |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
 | [`testing-library/prefer-user-event`](./docs/rules/prefer-user-event.md)                             | Suggest using `userEvent` over `fireEvent` for simulating user interactions                  |     |                                                                   |
 | [`testing-library/prefer-wait-for`](./docs/rules/prefer-wait-for.md)                                 | Use `waitFor` instead of deprecated wait methods                                             | 🔧  |                                                                   |

lib/configs/angular.ts

@@ -20,6 +20,7 @@ export = {
     'testing-library/no-wait-for-snapshot': 'error',
     'testing-library/prefer-find-by': 'error',
     'testing-library/prefer-presence-queries': 'error',
+    'testing-library/prefer-query-by-disappearance': 'error',
     'testing-library/prefer-screen-queries': 'error',
     'testing-library/render-result-naming-convention': 'error',
   },

lib/configs/dom.ts

@@ -15,6 +15,7 @@ export = {
     'testing-library/no-wait-for-snapshot': 'error',
     'testing-library/prefer-find-by': 'error',
     'testing-library/prefer-presence-queries': 'error',
+    'testing-library/prefer-query-by-disappearance': 'error',
     'testing-library/prefer-screen-queries': 'error',
   },
 };

lib/configs/react.ts

@@ -21,6 +21,7 @@ export = {
     'testing-library/no-wait-for-snapshot': 'error',
     'testing-library/prefer-find-by': 'error',
     'testing-library/prefer-presence-queries': 'error',
+    'testing-library/prefer-query-by-disappearance': 'error',
     'testing-library/prefer-screen-queries': 'error',
     'testing-library/render-result-naming-convention': 'error',
   },

lib/configs/vue.ts

@@ -21,6 +21,7 @@ export = {
     'testing-library/no-wait-for-snapshot': 'error',
     'testing-library/prefer-find-by': 'error',
     'testing-library/prefer-presence-queries': 'error',
+    'testing-library/prefer-query-by-disappearance': 'error',
     'testing-library/prefer-screen-queries': 'error',
     'testing-library/render-result-naming-convention': 'error',
   },

lib/rules/prefer-query-by-disappearance.ts

@@ -25,10 +25,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
         'Suggest using `queryBy*` queries when waiting for disappearance',
       category: 'Possible Errors',
       recommendedConfig: {
-        dom: false,
-        angular: false,
-        react: false,
-        vue: false,
+        dom: 'error',
+        angular: 'error',
+        react: 'error',
+        vue: 'error',
       },
     },
     messages: {

tests/__snapshots__/index.test.ts.snap

@@ -25,6 +25,7 @@ Object {
       "testing-library/no-wait-for-snapshot": "error",
       "testing-library/prefer-find-by": "error",
       "testing-library/prefer-presence-queries": "error",
+      "testing-library/prefer-query-by-disappearance": "error",
       "testing-library/prefer-screen-queries": "error",
       "testing-library/render-result-naming-convention": "error",
     },
@@ -44,6 +45,7 @@ Object {
       "testing-library/no-wait-for-snapshot": "error",
       "testing-library/prefer-find-by": "error",
       "testing-library/prefer-presence-queries": "error",
+      "testing-library/prefer-query-by-disappearance": "error",
       "testing-library/prefer-screen-queries": "error",
     },
   },
@@ -76,6 +78,7 @@ Object {
       "testing-library/no-wait-for-snapshot": "error",
       "testing-library/prefer-find-by": "error",
       "testing-library/prefer-presence-queries": "error",
+      "testing-library/prefer-query-by-disappearance": "error",
       "testing-library/prefer-screen-queries": "error",
       "testing-library/render-result-naming-convention": "error",
     },
@@ -104,6 +107,7 @@ Object {
       "testing-library/no-wait-for-snapshot": "error",
       "testing-library/prefer-find-by": "error",
       "testing-library/prefer-presence-queries": "error",
+      "testing-library/prefer-query-by-disappearance": "error",
       "testing-library/prefer-screen-queries": "error",
       "testing-library/render-result-naming-convention": "error",
     },