feat: add no-global-regex-flag-in-query rule

[timdeschryver]

Checks

• I have read the contributing guidelines.
• If some rule is added/updated/removed, I've regenerated the rules list.
• If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

• adds the new rule no-global-regex-flag-in-query

Context

Resolves #559

It's been a long time since I've contributed, feel free to comment on this PR :)

[Belco90]

@timdeschryver Thanks for implementing this so quickly! I added a couple of comments and asked for some small changes, but should be easy to address.

[timdeschryver]

@Belco90 and @MichaelDeBoey thanks for quick review.
I'll address these points tomorrow.
I also was thinking about a fixer that removes the regexp, thoughts?

[Belco90]

I also was thinking about a fixer that removes the regexp, thoughts?

I'd love to have the autofix, and should be fairly simple. However, I didn't want to request including this feature to merge this PR, so I'm happy about merging this one first and then add the autofix in a later PR if that's more convenient to you.

[timdeschryver]

@Belco90 the last commit refactors the implementation with getDeepestIdentifierNode. It does seem more robust to me, let me know what you think :)

[Belco90]

@timdeschryver Much better now, including the autofix function!

Just a couple of small tweaks and should be ready to go.

[Belco90]

This LGTM!

[github-actions]

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀