This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Fix type for normalizer filter function #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options normalizer filter function receives the node element instead of a string. Fixed the typescript definition for it.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 287 287
Branches 49 49
=====================================
Hits 287 287Continue to review full report at Codecov.
|
|
Thanks! @allcontributors[bot] please add @elyalvarado for code |
|
I've put up a pull request to add @elyalvarado! 🎉 |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed the options normalizer filter function typescript defintion to receive a node element instead of a string.
Why:
This is needed to pass an options object with a filter function to the queries when using javascript. Without this change is not possible to pass a filter function when using javascript without adding a
ts-ignorecomment.How:
I changed the typescript definition to use a NativeTestInstance instead of string for the first argument of the FilterFn type. I also changed the parameter name from value to node, to match the actual code.
Checklist:
docs site N/A