This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Fix #15 make render return bound queries passed as options #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions The documentation mentions that queries can be passed as an option to render to specify which queries to bind, or add custom bound queries. This commit fixes this behaviour and adds a regression test.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 287 287
Branches 49 49
=====================================
Hits 287 287
Continue to review full report at Codecov.
|
bcarroll22
approved these changes
May 5, 2019
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix #15 make render return bound queries passed as options
Why:
The documentation mentions that queries can be passed as an option to render to specify which queries to bind, or add custom bound queries. This commit fixes this behavior and adds a regression test.
How:
In the implementation of the
renderfunction it passes the receivedqueriesfrom options togetQueriesForElement.Checklist:
docs site N/A