Update queries.d.ts

[wolverineks]

What:

Update type of GetByText

Why:

Type was incorrect

How:

copied type from FindByText / docs

Checklist:

• Documentation added to the
  docs site
• Typescript definitions updated
• Tests
• Ready to be merged

[wolverineks]

should a typecheck be added to the ci?

[codecov]

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #51   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         262    262           
  Branches       65     65           
=====================================
  Hits          262    262

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fe158...765aa90. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@1b5a3a8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #51   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     20           
  Lines             ?    266           
  Branches          ?     67           
=======================================
  Hits              ?    266           
  Misses            ?      0           
  Partials          ?      0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5a3a8...d613807. Read the comment docs.

[wolverineks]

it also looks like getByText uses something called filter, and not selector, which is not in the MatcherOptions type

[wolverineks]

should there be a test that exercises each of the MatcherOptions options?

[bcarroll22]

Thanks for this!

I’m open to any improvements to the types or CI pipeline 👍 if you’d like to add more tests to cover extra scenarios, that works for me. The library itself is at 100% test coverage, so all of the matcher options and variations should be covered elsewhere in the tests already, but if you feel like there’s something missing feel free to add it!

[bcarroll22]

@wolverineks do we have any updates to this? should we merge or go back to the drawing board? for what it's worth, the rest of the organization either switched or is switching to the types repo, so we may want to just consider doing that here.

[wolverineks]

yeah, sorry, i went on vacation and i havent looked at it in a while.
im fine merging it now, and working on other changes if they become a problem, later
im fine with a types repo, i like the idea of consistency across all the testing-library flavors

[bcarroll22]

🎉 This PR is included in version 4.0.13 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀