Skip to content

Join testing-library org? #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentcdodds opened this issue Jun 1, 2019 · 13 comments
Closed

Join testing-library org? #18

kentcdodds opened this issue Jun 1, 2019 · 13 comments

Comments

@kentcdodds
Copy link
Member

Hi 👋 would you like to join @testing-library and move this over to that org? May help make this more official and you could also rename the module to @testing-library/preact if you're interested. Let me know!

@paulchaplin
Copy link

As a user of this project, I'm hugely in favour of that -- partly from an ease-of-discovery point of view, but also because I think it would encourage more independent contributions. Thanks to @antsmartian for everything so far, in any case!

@kentcdodds
Copy link
Member Author

Ping. Would you like some help @antsmartian?

@antsmartian
Copy link
Collaborator

@kentcdodds Sorry, was completely busy with my works. I will be moving this by next week for sure!

@tiagodreis
Copy link

What's the status on this? Any update @antsmartian ? Thanks!

@antsmartian
Copy link
Collaborator

@kentcdodds I tried to transfer this project as it is to testing-library. But I got the following error:
You don’t have the permission to create repositories on testing-library. Not sure, what is the mistake here.

@antsmartian
Copy link
Collaborator

antsmartian commented Sep 2, 2019

@kentcdodds I have given you the collaborator access to this repo. I believe, now you should be able to transfer this to testing-library. I would love to be part of testing-library as well, so that I can look into issues anything related to preact-testing-library. Hope you are ok with that :)

@kentcdodds
Copy link
Member Author

Just added you. You should be able to transfer it

@antsmartian
Copy link
Collaborator

@kentcdodds Thanks. Transferred. (Sorry for making it so long, given the fact its so simple). Happy to be part of @testing-library 🎉 🎉 🎉 🎉

@kentcdodds
Copy link
Member Author

Great! Would you like to publish preact-testing-library as @testing-library/preact? If so, I'll add you to the npm org and you can follow what I did for my libraries.

@antsmartian
Copy link
Collaborator

@kentcdodds I would be happy to. Can you please add me to the npm org, then will follow up on the instructions and do a npm publish.

@kentcdodds
Copy link
Member Author

I'd prefer to see a little more movement on #19 before we start publishing to the @testing-library scope. Also, I think it would be wise to have Rahim join as a co-maintainer of the package as it seems like you're not able to be as responsive as some of the community would like.

@antsmartian
Copy link
Collaborator

@kentcdodds Totally agree. I would close that thread with the recent changes of Rahim. Then we can take this forward.

@mihar-22
Copy link
Contributor

Closing this since we've already moved ahead in #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants