Merge branch 'main' into types/remove-unused

Author: eps1lon

.all-contributorsrc

@@ -1353,6 +1353,24 @@
       "contributions": [
         "doc"
       ]
+    },
+    {
+      "login": "yinm",
+      "name": "Yusuke Iinuma",
+      "avatar_url": "https://avatars.githubusercontent.com/u/13295106?v=4",
+      "profile": "http://yinm.info",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "trappar",
+      "name": "Jeff Way",
+      "avatar_url": "https://avatars.githubusercontent.com/u/525726?v=4",
+      "profile": "https://github.com/trappar",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "contributorsPerLine": 7,

.github/ISSUE_TEMPLATE/Bug_Report.md

@@ -60,13 +60,8 @@ https://github.com/testing-library/testing-library-docs
 ### Reproduction:
 
 <!--
-If possible, please create a repository that reproduces the issue with the
-minimal amount of code possible.
-
-Template repo: https://github.com/testing-library/dom-testing-library-template
-
-Or if you can, try to reproduce the issue in a Codesandbox. You can fork the one
-here: https://codesandbox.io/s/5z6x4r7n0p
+If possible, please try to reproduce this issue in Stackblitz. You can fork the one
+here: https://testing-library.com/new-rtl
 -->
 
 ### Problem description:

README.md

@@ -630,6 +630,8 @@ Thanks goes to these people ([emoji key][emojis]):
     </tr>
     <tr>
       <td align="center" valign="top" width="14.28%"><a href="http://cmdcolin.github.io"><img src="https://avatars.githubusercontent.com/u/6511937?v=4?s=100" width="100px;" alt="Colin Diesh"/><br /><sub><b>Colin Diesh</b></sub></a><br /><a href="https://github.com/testing-library/react-testing-library/commits?author=cmdcolin" title="Documentation">📖</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="http://yinm.info"><img src="https://avatars.githubusercontent.com/u/13295106?v=4?s=100" width="100px;" alt="Yusuke Iinuma"/><br /><sub><b>Yusuke Iinuma</b></sub></a><br /><a href="https://github.com/testing-library/react-testing-library/commits?author=yinm" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://github.com/trappar"><img src="https://avatars.githubusercontent.com/u/525726?v=4?s=100" width="100px;" alt="Jeff Way"/><br /><sub><b>Jeff Way</b></sub></a><br /><a href="https://github.com/testing-library/react-testing-library/commits?author=trappar" title="Code">💻</a></td>
     </tr>
   </tbody>
 </table>

jest.config.js

@@ -0,0 +1,16 @@
+const {jest: jestConfig} = require('kcd-scripts/config')
+
+module.exports = Object.assign(jestConfig, {
+  coverageThreshold: {
+    ...jestConfig.coverageThreshold,
+    // Full coverage across the build matrix (React versions) but not in a single job
+    // Ful coverage is checked via codecov
+    './src/pure.js': {
+      // minimum coverage of jobs using different React versions
+      branches: 97,
+      functions: 88,
+      lines: 94,
+      statements: 94,
+    },
+  },
+})

package.json

@@ -53,7 +53,7 @@
     "@testing-library/jest-dom": "^5.11.6",
     "chalk": "^4.1.2",
     "dotenv-cli": "^4.0.0",
-    "jest-diff": "^29.4.1",
+    "jest-diff": "^29.7.0",
     "kcd-scripts": "^13.0.0",
     "npm-run-all": "^4.1.5",
     "react": "^18.0.0",

src/__tests__/__snapshots__/render.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`supports fragments 1`] = `
+exports[`render API supports fragments 1`] = `
 <DocumentFragment>
   <div>
     <code>

src/__tests__/config.js

@@ -0,0 +1,66 @@
+import {configure, getConfig} from '../'
+
+describe('configuration API', () => {
+  let originalConfig
+  beforeEach(() => {
+    // Grab the existing configuration so we can restore
+    // it at the end of the test
+    configure(existingConfig => {
+      originalConfig = existingConfig
+      // Don't change the existing config
+      return {}
+    })
+  })
+
+  afterEach(() => {
+    configure(originalConfig)
+  })
+
+  describe('DTL options', () => {
+    test('configure can set by a plain JS object', () => {
+      const testIdAttribute = 'not-data-testid'
+      configure({testIdAttribute})
+
+      expect(getConfig().testIdAttribute).toBe(testIdAttribute)
+    })
+
+    test('configure can set by a function', () => {
+      // setup base option
+      const baseTestIdAttribute = 'data-testid'
+      configure({testIdAttribute: baseTestIdAttribute})
+
+      const modifiedPrefix = 'modified-'
+      configure(existingConfig => ({
+        testIdAttribute: `${modifiedPrefix}${existingConfig.testIdAttribute}`,
+      }))
+
+      expect(getConfig().testIdAttribute).toBe(
+        `${modifiedPrefix}${baseTestIdAttribute}`,
+      )
+    })
+  })
+
+  describe('RTL options', () => {
+    test('configure can set by a plain JS object', () => {
+      configure({reactStrictMode: true})
+
+      expect(getConfig().reactStrictMode).toBe(true)
+    })
+
+    test('configure can set by a function', () => {
+      configure(existingConfig => ({
+        reactStrictMode: !existingConfig.reactStrictMode,
+      }))
+
+      expect(getConfig().reactStrictMode).toBe(true)
+    })
+  })
+
+  test('configure can set DTL and RTL options at once', () => {
+    const testIdAttribute = 'not-data-testid'
+    configure({testIdAttribute, reactStrictMode: true})
+
+    expect(getConfig().testIdAttribute).toBe(testIdAttribute)
+    expect(getConfig().reactStrictMode).toBe(true)
+  })
+})