Skip to content

Pre-10.14 node versions not supported in 10.x versions of testing-library #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krynhild opened this issue May 10, 2020 · 2 comments
Closed

Pre-10.14 node versions not supported in 10.x versions of testing-library #665

krynhild opened this issue May 10, 2020 · 2 comments

Comments

@krynhild
Copy link

  • @testing-library/react version: 10.0.4

What you did:

Tried to install @testing-library/react 10.0.4 in the environment with node 10.13 and yarn 1.12.3.

What happened:

image

Reproduction:

See above.

Problem description:

According to this commit testing library is supposed to work with all node 10.x versions. However, dom-testing-library depends on [email protected] which requires >=node 10.14.2.

Suggested solution:

Change engines field to >=10.14.2.
@kentcdodds
Copy link
Member

Related: testing-library/dom-testing-library#563

I think we'll need to revert that update as suggested and push a breaking change instead.

@eps1lon
Copy link
Member

eps1lon commented Jun 2, 2021

Closing since node 10 has reached end-of-life anyway. We'll drop support for it in the next major anyway.

@eps1lon eps1lon closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kentcdodds @eps1lon @krynhild