Can't use TSX support in LanguageClient-neovim

[cormacrelf]

The languageId -> TS/TSX function only supports the languageIds used in VSCode. They are typescript, and typescriptreact for TSX.

In Vim, however, the convention is to use typescript.tsx, which means editing tsx files either doesn't work (typescript.tsx), or spews forth thousands of syntax errors (with just typescript). That option isn't configurable in LanguageClient-neovim, it must use the &filetype variable.

Could that function be amended to recognise the Vim form as well? Same goes for javascript.jsx.

[alextes]

@cormacrelf are you sure? The following appears to work fine for me:

let g:LanguageClient_serverCommands = {
      \ 'typescript': ['~/.node-bin/javascript-typescript-langserver', '--stdio'],
      \ 'typescript.tsx': ['~/.node-bin/javascript-typescript-langserver', '--stdio'],
      \}

[cormacrelf]

That’s what I did. You do have to be in a file with TSX in it.

[alextes]

Seems to be working fine too @cormacrelf . Did you try logging the client and server output?

tsconfig.json

{
  "compilerOptions": {
    "target": "ESNEXT",
    "module": "commonjs",
    "jsx": "preserve",
    "strict": true,
    "allowSyntheticDefaultImports": false,
    "esModuleInterop": true
  }
}

[BenoitZugmeyer]

I have the same issue, but I guess this is because leafgarland/typescript-vim does not set the filetype to typescript.tsx yet, see leafgarland/typescript-vim#140

[alextes]

Ah, now I understand the point @cormacrelf was making! Indeed, I use HerringtonDarkholme/yats.vim, it sets typescript.tsx.

[BenoitZugmeyer]

There is way too many TS vim plugins, and it seems the one from leafgarland is the most popular (most github stars) but not the most complete/effective (no TSX syntax highlighting, ...). I'll try yats.vim, thanks for sharing!

[everett1992]

Why does the file type need to be typescript.tsx to enable tsx support from the language server? I was bit by this because I use leafgarland/typescript-vim so my filetype was typescript.

[tsujp]

I'm having problem using typescript react with sublime LSP also, any fixes available nothing in this issue worked.

[tillydray]

@tsujp Add this line to your vimrc:

autocmd BufNewFile,BufRead *.tsx setlocal filetype=typescript.tsx.

I found this suggestion here. It did the trick.

If you want to know more about what the line does, search the help docs for autocmd :h autocmd. Basically any time a new file is being created or a file is being read, and it's a tsx file, it sets the filetype to typescript.tsx. You could do something silly and change css filetypes to js to see what happens.

[ta3pks]

alternatively adding a modeline is also an option instead of a autocmd I dont event have typescript.vim I dont really know why I am having this issue tho :D

[rchl]

The clients have to adjust to languageIds supported by this server, not the other way around. The IDs are pretty standardized these days across clients.

As for Sublime Text, you might just want to assign the TSX syntax to all typescript files. That shouldn't cause issues for plain TS files.