Skip to content

Parallel GPIO 8-bit interface does not work if the data bus pins are not zero on init #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andresovela opened this issue Feb 23, 2021 · 1 comment · Fixed by #20
Closed

Comments

@andresovela
Copy link
Contributor

When a new interface is created with PGPIO8BitInterface::new() the function assumes that all the pins are set to low beforehand. If that's not the case, the driver will start in an unexpected state because last is set to 0.

We should either drive the entire bus low on new(), or at least add this to the documentation. I would personally incline towards driving the pins low on initialization to ensure that the driver will work correctly even if the user fails to read one sentence in the documentation.

@andresovela andresovela changed the title Parallel GPIO 8-bit interface does not work if the data bus pins are not zero Parallel GPIO 8-bit interface does not work if the data bus pins are not zero on init Feb 23, 2021
@therealprof
Copy link
Owner

Makes sense, let's turn the pins into a defined state during initialisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants