Add tests for Updater input validation

This test covers `targetinfo`, `target_path`, `target_base_url`,
`metadata_dir` and `filepath` input validation of the `Updater`
methods

Signed-off-by: Ivana Atanasova <[email protected]>

Author: ivanayov

tests/test_updater_ng.py

@@ -314,6 +314,27 @@ def test_persist_metadata_fails(
         for filename in os.listdir(self.updater._dir):
             self.assertFalse(filename.startswith("tmp"))
 
+    def test_invalid_target_base_url(self) -> None:
+        info = TargetFile(1, {"sha256": ""}, "targetpath")
+        with self.assertRaises(exceptions.DownloadError):
+            self.updater.download_target(info, target_base_url="invalid_url")
+
+    def test_non_existing_target_file(self) -> None:
+        info = TargetFile(1, {"sha256": ""}, "/non_existing_file.txt")
+        # When non-existing target file is given, download fails with
+        # "404 Client Error: File not found for url"
+        with self.assertRaises(exceptions.FetcherHTTPError):
+            self.updater.download_target(info)
+
+    def test_empty_target_file_path(self) -> None:
+        # When target file path is empty, a listing of targets directory is fetched.
+        # This results in mismatch of expected length or hash. The test is written
+        # to fail on length mistmatch, as proper length can easily be changed in future
+        # by adding target files to tests.
+        info = TargetFile(1, {"sha256": ""}, "")
+        with self.assertRaises(exceptions.DownloadLengthMismatchError):
+            self.updater.download_target(info)
+
 
 if __name__ == "__main__":
     utils.configure_test_logging(sys.argv)

tests/test_updater_validation.py

@@ -0,0 +1,76 @@
+#!/usr/bin/env python
+
+# Copyright 2022, New York University and the TUF contributors
+# SPDX-License-Identifier: MIT OR Apache-2.0
+
+"""Test ngclient Updater validations.
+"""
+
+import os
+import sys
+import tempfile
+import unittest
+
+from tests import utils
+from tests.repository_simulator import RepositorySimulator
+from tuf import unittest_toolbox
+from tuf.ngclient import Updater
+
+
+class TestUpdater(unittest_toolbox.Modified_TestCase):
+    """Test ngclient Updater input validation."""
+
+    def setUp(self) -> None:
+        # pylint: disable-next=consider-using-with
+        self.temp_dir = tempfile.TemporaryDirectory()
+        self.metadata_dir = os.path.join(self.temp_dir.name, "metadata")
+        self.targets_dir = os.path.join(self.temp_dir.name, "targets")
+        os.mkdir(self.metadata_dir)
+        os.mkdir(self.targets_dir)
+
+        # Setup the repository, bootstrap client root.json
+        self.sim = RepositorySimulator()
+        with open(os.path.join(self.metadata_dir, "root.json"), "bw") as f:
+            f.write(self.sim.signed_roots[0])
+
+    def tearDown(self) -> None:
+        self.temp_dir.cleanup()
+
+    def _new_updater(self) -> Updater:
+        return Updater(
+            self.metadata_dir,
+            "https://example.com/metadata/",
+            self.targets_dir,
+            "https://example.com/targets/",
+            fetcher=self.sim,
+        )
+
+    def test_empty_target_path_validation(self) -> None:
+        updater = self._new_updater()
+        target_file = updater.get_targetinfo("")
+        self.assertIsNone(target_file)
+
+    def test_local_target_storage_fail(self) -> None:
+        self.sim.add_target("targets", b"content", "targetpath")
+        self.sim.targets.version += 1
+        self.sim.update_snapshot()
+
+        updater = self._new_updater()
+        target_info = updater.get_targetinfo("targetpath")
+        assert target_info is not None
+        with self.assertRaises(FileNotFoundError):
+            updater.download_target(target_info, filepath="")
+
+    def test_non_existing_metadata_dir(self) -> None:
+        with self.assertRaises(FileNotFoundError):
+            # Initialize Updater with non-existing metadata_dir
+            Updater(
+                "non_existing_metadata_dir",
+                "https://example.com/metadata/",
+                fetcher=self.sim,
+            )
+
+
+if __name__ == "__main__":
+    utils.configure_test_logging(sys.argv)
+    unittest.main()