Skip to content

Commit b37ebf7

Browse files
committed
Add lines and file count information
Signed-off-by: Martin Vrachev <[email protected]>
1 parent b9e838a commit b37ebf7

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

docs/adr/0007-validation-guideliness.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,25 @@ Here is how all of our options compare against our requirements:
4646
| 1 | Validate function args everywhere | Limited || Limited |||
4747
| 2 | Custom deeper validation ||||||
4848
| 3 | Performance overhead | Minimal | [Fastest](https://pydantic-docs.helpmanual.io/benchmarks/) | [Slower](https://pydantic-docs.helpmanual.io/benchmarks/) | No information | No information |
49-
| 4 | Number of new depedencies | 0 | 2 | 1 | 1 | 1 |
49+
| 4 | New [depedencies ; files ; lines of code;] | [0; no info; no info] | [2; 26; 8982] | [1; 13; 2652] | [1; 3; 899] | [1; 3; 899] |
5050
| 5 | Support for all python versions ||||||
5151
| 6 | Code reuse for validation ||||||
5252
| 7 | Way to invoke all validators ||||||
5353

54+
For requirement number 4, the calculations were made with [sloccount](https://linux.die.net/man/1/sloccount)
55+
on March 30-th 2021.
56+
Those results were concluded by performing the following steps for each of the
57+
options using third-party libraries:
58+
1. Creating a fresh virtual environment with python3.8.
59+
2. Installing all dependencies in `requirements-dev.txt` from `tuf`.
60+
3. Install `<package_name>` with `pip install <package_name>`.
61+
4. Use `sloccount` to count added lines and files by the package and its
62+
dependencies.
63+
64+
Only source files were used when calculating the lines of code and number of
65+
files (meaning all test files, doc folders, and other meta or configuration
66+
files were excluded).
67+
5468
Bellow, in the following sections, there are additional pros, cons, and
5569
considerations for each of the options.
5670

0 commit comments

Comments
 (0)