Skip to content

Commit b9c70aa

Browse files
committed
New API: Add a TODO comments
Signed-off-by: Martin Vrachev <[email protected]>
1 parent c37bdd2 commit b9c70aa

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

tuf/api/metadata.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,10 @@ def __init__(
381381
self, _type: str=None, version: int=None, spec_version: str=None,
382382
expires: datetime=None, consistent_snapshot: bool=None,
383383
keys: JsonDict=None, roles: JsonDict=None) -> None:
384+
385+
# TODO: Add sensible defaults when we have input validation.
386+
# See issue https://github.com/theupdateframework/tuf/issues/1140
387+
# We need default values to create empty objects in Signed.from_dict()
384388
super().__init__(_type, version, spec_version, expires)
385389
# TODO: Add classes for keys and roles
386390
self.consistent_snapshot = consistent_snapshot
@@ -493,6 +497,10 @@ def __init__(
493497
self, _type: str=None, version: int=None, spec_version: str=None,
494498
expires: datetime=None, meta: Dict[str, MetadataInfo]=None
495499
) -> None:
500+
501+
# TODO: Add sensible defaults when we have input validation.
502+
# See issue https://github.com/theupdateframework/tuf/issues/1140
503+
# We need default values to create empty objects in Signed.from_dict()
496504
super().__init__(_type, version, spec_version, expires)
497505
self.meta = meta
498506

@@ -528,6 +536,8 @@ def update(self, version: int, length: Optional[int] = None,
528536
hashes: Optional[JsonDict] = None) -> None:
529537
"""Assigns passed info about snapshot metadata to meta dict. """
530538

539+
# TODO: Consider renaming this function:
540+
# see: https://github.com/theupdateframework/tuf/issues/1230
531541
self.meta['snapshot.json'] = MetadataInfo(version, length, hashes)
532542

533543

@@ -549,6 +559,10 @@ def __init__(
549559
self, _type: str=None, version: int=None, spec_version: str=None,
550560
expires: datetime=None, meta: Dict[str, MetadataInfo]=None
551561
) -> None:
562+
563+
# TODO: Add sensible defaults when we have input validation.
564+
# See issue https://github.com/theupdateframework/tuf/issues/1140
565+
# We need default values to create empty objects in Signed.from_dict()
552566
super().__init__(_type, version, spec_version, expires)
553567
self.meta = meta
554568

@@ -587,6 +601,9 @@ def update(
587601
self, rolename: str, version: int, length: Optional[int] = None,
588602
hashes: Optional[JsonDict] = None) -> None:
589603
"""Assigns passed (delegated) targets role info to meta dict. """
604+
605+
# TODO: Consider renaming this function:
606+
# see: https://github.com/theupdateframework/tuf/issues/1230
590607
metadata_fn = f'{rolename}.json'
591608

592609
self.meta[metadata_fn] = MetadataInfo(version, length, hashes)
@@ -697,6 +714,10 @@ def __init__(
697714
self, _type: str=None, version: int=None, spec_version: str=None,
698715
expires: datetime=None, targets: Dict[str, TargetInfo]=None,
699716
delegations: JsonDict=None) -> None:
717+
718+
# TODO: Add sensible defaults when we have input validation.
719+
# See issue https://github.com/theupdateframework/tuf/issues/1140
720+
# We need default values to create empty objects in Signed.from_dict()
700721
super().__init__(_type, version, spec_version, expires)
701722
self.targets = targets
702723

@@ -737,5 +758,8 @@ def to_dict(self) -> JsonDict:
737758
# Modification.
738759
def update(self, filename: str, fileinfo: JsonDict) -> None:
739760
"""Assigns passed target file info to meta dict. """
761+
762+
# TODO: Consider renaming this function:
763+
# see: https://github.com/theupdateframework/tuf/issues/1230
740764
self.targets[filename] = TargetInfo(fileinfo['length'],
741765
fileinfo['hashes'], fileinfo.get('custom'))

0 commit comments

Comments
 (0)