Skip to content

Resource warnings when running the test files #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MVrachev opened this issue Sep 9, 2020 · 2 comments · Fixed by #1226
Closed

Resource warnings when running the test files #1123

MVrachev opened this issue Sep 9, 2020 · 2 comments · Fixed by #1226
Labels

Comments

@MVrachev
Copy link
Collaborator

MVrachev commented Sep 9, 2020

Description of issue or feature request:
When you run python <test_file> on the development branch we are getting resource warnings.

Current behavior:
For example, if you run python test_download.py from the tests directory you will get:
image

Expected behavior:
No unclosed files, sockets, or resources as a whole to be left after a test run and thus no resource warnings to be found.

@jku
Copy link
Member

jku commented Sep 9, 2020

This might be same as #1099 (but I'm not sure)

@MVrachev
Copy link
Collaborator Author

MVrachev commented Sep 9, 2020

Maybe, but this problem exists not only in the test_updater.py, but most likely in almost all of our test files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants