Skip to content

client refactor: review _get_*_meta_name() usage #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jku opened this issue Mar 18, 2021 · 2 comments
Closed

client refactor: review _get_*_meta_name() usage #1319

jku opened this issue Mar 18, 2021 · 2 comments
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)
Milestone
Experimental client

Comments

@jku
Copy link
Member

jku commented Mar 18, 2021

Simplify and remove duplication from metadata filename handling (_get_relative_meta_name(),_get_full_meta_name())

  • remove duplication
  • probably no need to make the extension modifiable: .json is fine
  • there are cases of _get_full_meta_name('timestamp.json') -- this seems like a bug?
@jku jku added the experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch) label Mar 18, 2021
@sechkova sechkova added this to the Client Refactor milestone Apr 7, 2021
@sechkova
Copy link
Contributor

To be resolved with #1396

@jku jku mentioned this issue May 19, 2021
Merged
@sechkova
Copy link
Contributor

Closed with #1396.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)
Projects
None yet
Milestone
Experimental client
Development

No branches or pull requests
2 participants
@jku @sechkova