Skip to content

Metadata API: stop using formats.py #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jku opened this issue May 12, 2021 · 1 comment · Fixed by #1432
Closed

Metadata API: stop using formats.py #1384

jku opened this issue May 12, 2021 · 1 comment · Fixed by #1432
Assignees
@avelichka
Labels
backlog Issues to address with priority for current development goals good first issue Bite-sized items for first time contributors
Milestone
weeks22-23

Comments

@jku
Copy link
Member

jku commented May 12, 2021 •
edited
Loading

Currently we have one use of tuf/formats.py in tuf/api/metadata.py. I think we should try to keep the two implementations separate.

Current behavior:
formats.expiry_string_to_datetime() is used in metadata.py

Expected behavior:
We should do the conversion in metadata.py (and I think we should not raise securesystemslib errors like current implementation does).
@jku jku added the good first issue Bite-sized items for first time contributors label May 12, 2021
@jku jku mentioned this issue May 24, 2021
Merged
@jku jku added the backlog Issues to address with priority for current development goals label May 26, 2021
@sechkova sechkova added this to the weeks22-23 milestone May 26, 2021
@avelichka
Copy link
Contributor

I'd like to work on that :)

@MVrachev MVrachev mentioned this issue May 26, 2021
Closed
@avelichka avelichka mentioned this issue Jun 2, 2021
Merged
3 tasks
@jku jku closed this as completed in #1432 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avelichka avelichka

Labels
backlog Issues to address with priority for current development goals good first issue Bite-sized items for first time contributors
Projects
None yet
Milestone
weeks22-23
Development

Successfully merging a pull request may close this issue.

Stop using formats.py in metadata.py avelichka/tuf
3 participants
@jku @sechkova @avelichka