Skip to content

RepositorySimulator: inconsistent behaviour of compute_metafile_hashes_length #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sechkova opened this issue Oct 29, 2021 · 1 comment · Fixed by #1695
Closed

RepositorySimulator: inconsistent behaviour of compute_metafile_hashes_length #1651

sechkova opened this issue Oct 29, 2021 · 1 comment · Fixed by #1695
Assignees
Labels
backlog Issues to address with priority for current development goals bug testing
Milestone

Comments

@sechkova
Copy link
Contributor

sechkova commented Oct 29, 2021

Description of issue or feature request:

RepositorySimulator.compute_metafile_hashes_length is documented as a boolean deciding " Whether to compute hashes and length for meta in snapshot/timestamp".

  • When calculating snapshot metafile's hashes in update_timestamp and compute_metafile_hashes_length is switched to False, the old hashes and length still remain.
  • When calculating targets metafile's hashes in update_snapshot and compute_metafile_hashes_length is switched to False, the old hashes and length are cleaned up and the new values are set to None.

Expected behavior:
The correct behaviour should be the one in update_snapshot (clean up the hashes and length) and it needs to be replicated in update_timestamp.

@jku jku changed the title RepositorySumulator: inconsistent behaviour of compute_metafile_hashes_length RepositorySimulator: inconsistent behaviour of compute_metafile_hashes_length Nov 2, 2021
@sechkova sechkova added the backlog Issues to address with priority for current development goals label Nov 10, 2021
@ivanayov
Copy link
Collaborator

Can I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals bug testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants