Skip to content

Add support for unrecognized_fields inside Metadata #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MVrachev opened this issue Feb 9, 2022 · 0 comments · Fixed by #1861
Closed

Add support for unrecognized_fields inside Metadata #1852

MVrachev opened this issue Feb 9, 2022 · 0 comments · Fixed by #1861
Assignees
Labels
1.0.0 blockers To be addressed before 1.0.0 release
Milestone

Comments

@MVrachev
Copy link
Collaborator

MVrachev commented Feb 9, 2022

Description of issue or feature request:

The Document formats section of the specification says the following:

All of the formats described below include the ability to add more attribute-value fields
to objects for backward-compatible format changes.
Implementers who encounter undefined attribute-value pairs in the format must include
the data when calculating hashes or verifying signatures and
must preserve the data when re-serializing.

I initially thought it's applicable only to the SIGNED fields as undefined attribute-value pairs in the format must include the data when calculating hashes or verifying signatures.
This doesn't mean that the sentence before that excludes Metadata as a possible place for additional fields.
The other maintainers agreed with me and we are going to add support for unrecognized_fields inside Metadata.

For context read:

@MVrachev MVrachev self-assigned this Feb 9, 2022
@MVrachev MVrachev added this to the sprint 17 milestone Feb 9, 2022
@MVrachev MVrachev added the 1.0.0 blockers To be addressed before 1.0.0 release label Feb 9, 2022
@jku jku closed this as completed in #1861 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 blockers To be addressed before 1.0.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant