Skip to content

Add some more generated metadata files #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jku opened this issue Mar 23, 2022 · 2 comments
Open

Add some more generated metadata files #1920

jku opened this issue Mar 23, 2022 · 2 comments
Labels
backlog Issues to address with priority for current development goals testing

Comments

@jku
Copy link
Member

jku commented Mar 23, 2022

#1915 adds metadata generation (with stored expected results). We should expand the collection in two directions:

  • The current metadata is basically all with default values: Add More variation on the metadata (different key types, delegations, targets, etc)
  • Include actual repositories (that are confirmed to work as repositories), possibly with several versions of the same repository: Note that we should be careful not to duplicate the code in RepositorySimulator based updater tests: possibly we could just make RepositorySimulator generated data reproducible and store the results of the RepositorySimulator runs (see the --dump option for related tests)

I'll assign to myself: I'll probably handle the first item and file a new issue on the second but let's see...

@jku jku added this to the Sprint 20 milestone Mar 23, 2022
@jku jku self-assigned this Mar 23, 2022
@jku
Copy link
Member Author

jku commented Mar 23, 2022

Pasting in my notes on 1915:

  • The key & signer handling could probably be better (why does the generator function need to construct the signers?) but there's no need to polish everything before we know what the code is going to be like...
  • The error message could mention that new expected results should only be generated if the change in results was expected
    script only works if run from a specific working directory
  • two separate arguments (dump/verify) is weird: that leads to 4 distinct modes but only two of them make sense...

@jku
Copy link
Member Author

jku commented Apr 6, 2022

Unassigning for now: too busy to handle this right now

@jku jku removed their assignment Apr 6, 2022
@ivanayov ivanayov added testing backlog Issues to address with priority for current development goals labels Apr 20, 2022
@ivanayov ivanayov removed this from the Sprint 20 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals testing
Projects
None yet
Development

No branches or pull requests

2 participants