expect_error() is being used too much

[EmilHvitfeldt]

as an example the following test https://github.com/tidymodels/parsnip/blob/main/tests/testthat/test_decision_tree.R#L15-L18

  expect_snapshot_error({
    bt <- decision_tree(cost_complexity = -1) %>% set_engine("rpart")
    fit(bt, class ~ ., hpc)
  })

is expected to test that cost_complexity isn’t good, but it instead tests that the mode isn’t set

#> Error in `fit()`:
#> ! Please set the mode in the model specification.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.